[JIRA] (JENKINS-54496) Node monitoring should not log exceptions for disconnected nodes

[pjdar...@gmail.com (JIRA)]

Title: Message Title

pjdarton commented on JENKINS-54496   Re: Node monitoring should not log exceptions for disconnected nodes I've done a bit of digging and I think that the answer may be to modify AbstractAsyncNodeMonitorDescriptor's private void error(Computer c, Throwable x) method so that instead of this: private void error(Computer c, Throwable x) { if (c instanceof SlaveComputer) { Functions.printStackTrace(x, ((SlaveComputer) c).getListener().error("Failed to monitor for " + getDisplayName())); } else { LOGGER.log(WARNING, "Failed to monitor " + c.getDisplayName() + " for " + getDisplayName(), x); } } it does this private void error(Computer c, Throwable x) { // JENKINS-54496: don't log if c was removed from Jenkins after we'd started monitoring final boolean cIsStillCurrent = Jenkins.get().getComputer(c.getName()) == c; if (!cIsStillCurrent) { return; } if (c instanceof SlaveComputer) { Functions.printStackTrace(x, ((SlaveComputer) c).getListener().error("Failed to monitor for " + getDisplayName())); } else { LOGGER.log(WARNING, "Failed to monitor " + c.getDisplayName() + " for " + getDisplayName(), x); } } If I can persuade my dev environmemt to build me a custom jenkins.war with this code change, I'll be able to try that out and see if that resolves the issue ... but in the meantime, WDYT? Add Comment   This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.195266.1541524267000.8311.1580309100125%40Atlassian.JIRA.