[JIRA] (JENKINS-61245) Nested node blocks referring to the same node take two (or more) executors

[rjfen...@mtu.edu (JIRA)]

Title: Message Title

Ryan Fenton-Garcia created an issue   Jenkins / JENKINS-61245 Nested node blocks referring to the same node take two (or more) executors Issue Type: Bug Assignee: Unassigned Components: pipeline Created: 2020-02-26 20:07 Environment: Jenkins 2.204.2 Pipeline 2.6 Windows Server 2016 Labels: scripted pipeline Priority: Minor Reporter: Ryan Fenton-Garcia We have a pipeline wherein there is a function that has to may need to be called from multiple places. The code in this function needs to run on master. So we have: def someFunction { node("master") { // do the stuff that needs master } } Now what we recently found out is that if/when this function is called from code already running on master it will actually lock not just the current executor it is using on master but an additional executor as well.  To further investigate this, we found out that even doing something as simple as... node("master") { node("master") { sleep(600) } }  ...in a test job, actually locks two executors on master, if you have more than one executor, or hangs indefinitely "Waiting for next available executor on 'master'" even though the only thing using the only executor on master is already this block of code.  I'd suspect this isn't just the case for master, but actually the case for any code specifying that it needs run on a label that it's possible already running on. I think a possible work around for code that needs to execute in this fashion is to write all these blocks of code like this: if ("${NODE_NAME}" != "master") { node("master") { // do my code } } else { // do my code } Or else wrap this into a closure of some sort of it's own... and call nodeIfNotAlreadyOn("master") instead or something. But this isn't exactly very nice, and not exactly the behaviour I was initially expecting. Add Comment   This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.204811.1582747638000.313.1582747680104%40Atlassian.JIRA.