[JIRA] (JENKINS-41308) support Use Groovy Sandbox scripts in activeChoiceParams

[email protected] (JIRA) Mon, 09 Mar 2020 01:43:31 -0700

Title: Message Title

Adam Gabryś commented on

JENKINS-41308

It is possible to use Dynamic DSL. Unfortunately, it has two disadvantages:

it forces to set all parameters, even those which we don't want to set (the default values are fine for us). This behavior is also a cause that the code could stop working after the 3rd-party plugin update (for example a new field has been added)
the code which does simple stuff is much longer and less readable

Examples:

Dynamic DSL:

 
                                                                        choiceParameter {
    delegate.name(name)
    delegate.description(description)
    delegate.choiceType('PT_RADIO')
    delegate.script {
        groovyScript {
            script {
                script(valuesToString())
                sandbox(true)
            }
            fallbackScript{
                script('')
                sandbox(true)
            }
        }
    }
    delegate.randomName('')
    delegate.filterable(false)
    delegate.filterLength(0)
}
 
                                                                    

Static DSL:

 
                                                                        activeChoiceParam(name) {
    delegate.description(this.description)
    delegate.choiceType('RADIO')
    delegate.groovyScript {
        script(valuesToString()) {
            sandbox()
        }
    }
}
 
                                                                    

As a user I would be really happy to have this feature merged.

From the other side, if you don't want to merge anything related to static DSL, it would be good if you could mark it as deprecated. Keeping it in the current state confuses the users. They use and even create PRs to the code which is frozen (never will be changed - according to the statement that all PRs are declined).

Add Comment

This message was sent by Atlassian Jira

--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.178082.1485160940000.2756.1583743380369%40Atlassian.JIRA.

[JIRA] (JENKINS-41308) support Use Groovy Sandbox scripts in activeChoiceParams

Reply via email to