[JIRA] (JENKINS-62116) Organization Scan recreates hooks for all repository

[aburdajew...@cloudbees.com (JIRA)]

Title: Message Title

Allan BURDAJEWICZ created an issue   Jenkins / JENKINS-62116 Organization Scan recreates hooks for all repository Issue Type: Bug Assignee: Kirill Merkushev Components: github-branch-source-plugin, github-plugin Created: 2020-04-30 01:05 Environment: github-branch-source:2.6.0 core:2.222.2 Priority: Major Reporter: Allan BURDAJEWICZ The organization scan recreates a hook for all repositories for which there is an item. We can see that A WebHook is created / updated with events "[PULL_REQUEST, PUSH]" and then the webhook is replaced with events "[PULL_REQUEST, PUSH, REPOSITORY]". Apr 30, 2020 12:42:08 AM FINE com.cloudbees.jenkins.GitHubWebHook$1 apply Calling registerHooks() for dse-team-apac/aburdajewicz/testOrg/public-repo Apr 30, 2020 12:42:08 AM INFO org.jenkinsci.plugins.github.webhook.WebhookManager$1 run GitHub webhooks activated for job dse-team-apac/aburdajewicz/testOrg/public-repo with [GitHubRepositoryName[host=github.example.com,username=test-org,repository=public-repo]] (events: [PULL_REQUEST, PUSH]) Apr 30, 2020 12:42:09 AM FINE org.jenkinsci.plugins.github.webhook.WebhookManager$3 applyNullSafe Replaced hook https://github.example.com/api/v3/repos/test-org/public-repo/hooks/32392 (events: [PULL_REQUEST, PUSH, REPOSITORY]) Apr 30, 2020 12:42:09 AM FINE org.jenkinsci.plugins.github.webhook.WebhookManager$3 applyNullSafe Created hook https://github.example.com/api/v3/repos/test-org/public-repo/hooks/32394 (events: [PULL_REQUEST, PUSH, REPOSITORY]) Apr 30, 2020 12:42:10 AM FINE com.cloudbees.jenkins.GitHubWebHook$1 apply Calling registerHooks() for dse-team-apac/aburdajewicz/testOrg/private-repo Apr 30, 2020 12:42:10 AM INFO org.jenkinsci.plugins.github.webhook.WebhookManager$1 run GitHub webhooks activated for job dse-team-apac/aburdajewicz/testOrg/private-repo with [GitHubRepositoryName[host=github.example.com,username=test-org,repository=private-repo]] (events: [PULL_REQUEST, PUSH]) Apr 30, 2020 12:42:10 AM FINE org.jenkinsci.plugins.github.webhook.WebhookManager$3 applyNullSafe Replaced hook https://github.example.com/api/v3/repos/test-org/private-repo/hooks/32393 (events: [PULL_REQUEST, PUSH, REPOSITORY]) Apr 30, 2020 12:42:10 AM FINE org.jenkinsci.plugins.github.webhook.WebhookManager$3 applyNullSafe Created hook https://github.example.com/api/v3/repos/test-org/private-repo/hooks/32395 (events: [PULL_REQUEST, PUSH, REPOSITORY]) The GitHub audit log is then showing a "hook.destroy" / "hook.create" for each repository. API rate seems to be wasted and those recreation seem unnecessary. The differenc eof events h3 How to Reproduce Configure a GitHub Server under *Manage Jenkins > Configure System > GitHub* and enabled "Manage Hooks" Create a log recorder in *Manage Jenkins > System Logs* for org.jenkinsci.plugins.github.webhook.WebhookManager, com.cloudbees.jenkins.GitHubWebHook Create an GitHub Organization item that match at least one repo Run the Organization Scan a few times Check the log recorder and also the Audit log at $GITHUB_ORG_URL/settings/audit-log, You shell see that hooks are replaced on Organization Scan. Add Comment   This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.206027.1588208750000.19744.1588208760250%40Atlassian.JIRA.