[JIRA] (JENKINS-62157) GitHub Enterprise rate limiting no longer working

[bfarr...@us.ibm.com (JIRA)]

Title: Message Title

Brian Farrell created an issue   Jenkins / JENKINS-62157 GitHub Enterprise rate limiting no longer working Issue Type: Bug Assignee: Unassigned Components: github-branch-source-plugin Created: 2020-05-04 14:10 Environment: github-branch-source v2.6.0 Priority: Major Reporter: Brian Farrell The changes in JENKINS-59039 have broken rate limiting on our GitHub Enterprise instance. This GHE instance does not return rate limit information via the /rate_limit endpoint { "message": "Rate limiting is not enabled.", "documentation_url": "https://developer.github.com/enterprise/2.19/v3/rate_limit/#get-your-current-rate-limit-status" } but does return X-RateLimit headers on every request: < X-RateLimit-Limit: 5000 < X-RateLimit-Reset: 1588603124 < X-RateLimit-Remaining: 4999 Before JENKINS-59039, it looks like the code called org.kohsuke.github.GitHub#rateLimit, which will return header-based rate limit info if it exists. Now the code calls org.kohsuke.github.GitHub#getRateLimit, which exclusively uses the /rate_limit endpoint. The end result is that the plugin does not throttle itself during organization/repository scanning and for repositories with large numbers of branches, the scan ends up failing when the rate limit is exceeded. Unfortunately I don't think modifying the response of the /rate_limit endpoint is an option. Any chance the plugin can be modified to call org.kohsuke.github.GitHub#rateLimit like it used to? Add Comment   This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.206080.1588601416000.21140.1588601460103%40Atlassian.JIRA.