Issue Type: Bug Bug
Assignee: Gregory Boissinot
Components: buildresulttrigger
Created: 18/Jun/13 4:22 PM
Description:

The build result trigger constantly triggers jobs when the build number is not low.

Issue caused by comparing two Integer objects with == rather than equals()

patch inline

diff --git a/src/main/java/org/jenkinsci/plugins/buildresulttrigger/BuildResultTrigger.java b/src/mai
index c6946e3..192947f 100644
--- a/src/main/java/org/jenkinsci/plugins/buildresulttrigger/BuildResultTrigger.java
+++ b/src/main/java/org/jenkinsci/plugins/buildresulttrigger/BuildResultTrigger.java
@@ -168,7 +168,7 @@ public class BuildResultTrigger extends AbstractTriggerByFullContext<BuildResult
         }

         //Process if there is a new build between now and previous polling
-        if (newLastBuildNumber == 0 || newLastBuildNumber != oldLastBuildNumber) {
+        if (newLastBuildNumber == 0 || ! newLastBuildNumber.equals(oldLastBuildNumber)) {
             return isMatchingExpectedResults(configuredTriggerJobInfo, log);
         }
Project: Jenkins
Priority: Blocker Blocker
Reporter: teilo
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
 
 

Reply via email to