[JIRA] [build-pipeline] (JENKINS-16748) Build Pipeline Plugin views are not filtered

Mon, 29 Jul 2013 17:44:20 -0700

From my reading of this: https://github.com/jenkinsci/jenkins/commit/85e13303f8cfbebeb7dab347fda8ccf4069070b6 (from https://issues.jenkins-ci.org/browse/JENKINS-3681)

The getItems() call must not be returning an empty collection for a user that does not have permissions on the jobs used in the pipeline, and the getItems() call for a build pipeline view is (https://github.com/jenkinsci/build-pipeline-plugin/blob/master/src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView.java)

@Override
    public Collection<TopLevelItem> getItems() {
        return Hudson.getInstance().getItems();
    }


Jenkins internals aren't my strongest skills, but I wonder would the following change help with this?



Change BuildPipelineView.getItems() to:




@Override
    public Collection<TopLevelItem> getItems() {
        return this.gridBuilder.getFirstJob(this).getItems();
    }
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
 
 

Reply via email to