[JIRA] [ssh-credentials] (JENKINS-21283) BasicSSHUserPrivateKey.getPassphrase breaks nullness contract of interface

[jgl...@cloudbees.com (JIRA)]

Jesse Glick created JENKINS-21283 BasicSSHUserPrivateKey.getPassphrase breaks nullness contract of interface Issue Type: Bug Assignee: stephenconnolly Components: ssh-credentials Created: 08/Jan/14 7:25 PM Description: SSHUserPrivateKey.getPassphrase is documented to return null if the private key is not protected by passphrase. Yet the constructor of BasicSSHUserPrivateKey does not check for an empty passphrase, and Secret.fromString never returns null, so getPassphrase returns a non-null result even if none was specified (in this case .getPassphrase().getPlainText().isEmpty()). Project: Jenkins Priority: Major Reporter: Jesse Glick

This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira

--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.