[JIRA] [windows-slaves] (JENKINS-21373) Unable to connect to Windows slave after upgrade to Jenkins ver. 1.547

Tue, 28 Jan 2014 04:19:20 -0800

David Frank commented on Bug JENKINS-21373

hi,
looking at the code (for the first time - so forgive me if I'm wrong..) I think method

private EnvVars getEnvVars(Hudson h) { return getEnvVars(h.getGlobalNodeProperties()); }

is no longer there (compared with https://github.com/jenkinsci/jenkins/blob/934e9d336b7fb1fb41506fdd525ac98acbf91240/core/src/main/java/hudson/os/windows/ManagedWindowsServiceLauncher.java) with leads to code in

private EnvVars getEnvVars(SlaveComputer computer)

fetching only environment variables by calling

private EnvVars getEnvVars(Node n) { return getEnvVars(n.getNodeProperties()); }

twice instead of merging local and global ones.
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to