[JIRA] [cppcheck] (JENKINS-22214) Fix findings from FindBugs static analysis

[scm_issue_l...@java.net (JIRA)]

SCM/JIRA link daemon commented on JENKINS-22214 Fix findings from FindBugs static analysis Code changed in jenkins User: Michal Turek Path: src/main/java/com/thalesgroup/hudson/plugins/cppcheck/CppcheckMetricUtil.java src/main/java/com/thalesgroup/hudson/plugins/cppcheck/CppcheckResult.java src/main/java/com/thalesgroup/hudson/plugins/cppcheck/model/CppcheckSourceContainer.java src/main/java/com/thalesgroup/hudson/plugins/cppcheck/model/CppcheckWorkspaceFile.java src/main/java/org/jenkinsci/plugins/cppcheck/config/CppcheckConfig.java src/main/java/org/jenkinsci/plugins/cppcheck/config/CppcheckConfigGraph.java src/main/java/org/jenkinsci/plugins/cppcheck/config/CppcheckConfigSeverityEvaluation.java src/main/java/org/jenkinsci/plugins/cppcheck/util/CppcheckMetricUtil.java src/test/java/com/thalesgroup/hudson/plugins/cppcheck/AbstractWorkspaceTest.java src/test/java/com/thalesgroup/hudson/plugins/cppcheck/CppcheckParserTest.java src/test/java/org/jenkinsci/plugins/cppcheck/CppcheckParserTest.java http://jenkins-ci.org/commit/cppcheck-plugin/1aa01f225235d1763a8523b9c8caf7838c311ec4 Log: JENKINS-22214 Fix findings from FindBugs static analysis CppcheckMetricUtil: A boxed primitive is created from a String, just to extract the unboxed primitive value. It is more efficient to just call the static parseXXX method. CppcheckResult: Private method com.thalesgroup.hudson.plugins.cppcheck.CppcheckResult.getPreviousReport() is never called. CppcheckResult: Class com.thalesgroup.hudson.plugins.cppcheck.CppcheckResult defines non-transient non-serializable instance field cppcheckSourceContainer. CppcheckSource: Class com.thalesgroup.hudson.plugins.cppcheck.CppcheckSource defines non-transient non-serializable instance field cppcheckWorkspaceFile. AbstractWorkspaceTest: AbstractWorkspaceTest.workspace not initialized in constructor and dereferenced in com.thalesgroup.hudson.plugins.cppcheck.AbstractWorkspaceTest.deleteWorkspace(). CppcheckParserResultTestCppcheckParserResultTest: AbstractWorkspaceTest.workspace not initialized in constructor and dereferenced in com.thalesgroup.hudson.plugins.cppcheck.CppcheckParserResultTest.testNoMatch(). CppcheckParserTest: Usage of GetResource in com.thalesgroup.hudson.plugins.cppcheck.CppcheckParserTest.processCheckstyle(String, int, int, int, int, int, int) may be unsafe if class is extended. serialVersionUID member variables defined in serializable classes. Unneccessary @SuppressWarnings("unused") removed to solve compiler warnings.

This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira

--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.