Jesse Glick commented on Bug JENKINS-22245

Indeed no code should be making a network request in the course of page rendering. Currently seems to use cached results for five minutes, but should not ever do this calculation synchronously. By the way loading an image asynchronously would not suffice as the user name is used also in a hyperlink; would need to use l:renderOnDemand (with l:ajax) or similar.

Also it seems inappropriate for PluginImpl.disableStatusColumn to default to false. Would be more polite for SauceBadgeColumn.DescriptorImpl.shownByDefault to simply be false, where users would add the column to whichever views they wanted to see it on; this is how most plugin-contributed columns work.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to