[JIRA] [subversion] (JENKINS-21785) Check for changes in folders linked via svn:externals fails due to missing credentials

[dan...@beckweb.net (JIRA)]

Daniel Beck edited a comment on JENKINS-21785 Check for changes in folders linked via svn:externals fails due to missing credentials Christoph Vogtländer: Issue appears for me when running the following: def p = Jenkins.instance.getItemByFullName('job-with-svn-with-externals'); p.scm.with { it.getProjectLocations(p).each { loc -> println loc println loc.getUUID(p) } } This mirrors the behavior of Jenkins during the post-commit hook. Proposed patch that resolves the issue for me (on top of PR 70): $ git diff diff --git a/src/main/java/hudson/scm/SubversionSCM.java b/src/main/java/hudson/scm/SubversionSCM.java index 938b39b..75db1e1 100755 --- a/src/main/java/hudson/scm/SubversionSCM.java +++ b/src/main/java/hudson/scm/SubversionSCM.java @@ -2736,7 +2736,7 @@ public class SubversionSCM extends SCM implements Serializable { StandardCredentials cred = CredentialsMatchers .firstOrNull(CredentialsProvider.lookupCredentials(StandardCredentials.class, context, ACL.SYSTEM, Collections.<DomainRequirement>emptyList()), - CredentialsMatchers.allOf(CredentialsMatchers.withId(credentialsId), + CredentialsMatchers.allOf(CredentialsMatchers.withId(c.getCredentialsId()), CredentialsMatchers.anyOf(CredentialsMatchers.instanceOf( StandardCredentials.class), CredentialsMatchers.instanceOf( SSHUserPrivateKey.class)))); Will probably open the PR tomorrow.

This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira

--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.