![]() |
|
|
|
|
Issue Type:
|
![Bug]() Bug
|
|
Assignee:
|
Unassigned |
|
Components:
|
core |
|
Created:
|
02/Apr/14 5:58 PM
|
|
Description:
|
Some CommandDuringBuild implementations, such as SetBuildResultCommand, check permissions. (Oddly, Item.BUILD in this case; I would have expected Run.UPDATE. And SetBuildParameterCommand does no check at all.) This is necessary to prevent a random user (with at least Item.READ permission) from running one of these commands on someone else's build from an external command shell. (getCurrentlyBuilding does not even check Run.isBuilding, so this could even be used to mangle a completed build's state, such as parameters via SetBuildParameterCommand. SetBuildResultCommand would not work on a finished build because of checks inside Run.setResult.)
Yet Jenkins provides no assistance in authenticating such commands. So if you are running in a properly secured instance and want to run set-build-result, your job would have to provide an SSH private key or password for a user with permissions on the job. Managing such credentials safely could be tricky.
It would be better if this were automatic, when the CLI command is indeed run from inside the build (say in a shell step). Perhaps $JENKINS_SERVER_COOKIE could be inspected on the CLI side and compared to Run.getCharacteristicEnvVars? Assuming there is a match, you could either
- Set the transport authentication for the command to the authentication in effect in Run.getExecutor, if not just SYSTEM. (Executor would need to have a method reporting its current authentication. Running workUnit.context.item.authenticate() again and assuming that the result is the same is unsafe since a job configuration might have changed since it started running.)
- Return null from getCurrentlyBuilding in case there is not a match, and removing permission checks from command implementations. This is arguably better because it will make the job work correctly even if the authentication in effect during the build is for a user (for example anonymous) who would not otherwise generally have those permissions on the job; or when there is no authentication in effect during the build at all.
|
|
Project:
|
Jenkins
|
|
Labels:
|
cli
security
|
|
Priority:
|
![Major]() Major
|
|
Reporter:
|
Jesse Glick
|
|
|
|
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
|
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to
[email protected].
For more options, visit
https://groups.google.com/d/optout.
