Change By: evernat (20/Apr/14 10:06 AM)
Description: A FileInputStream is not closed in [hudson.model.FileParameterValue|https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/model/FileParameterValue.java#L260] for "return IOUtils.toByteArray(new FileInputStream(file))".
This is a resource leak.

The FileInputStream should be closed, using finally. For example:
{code}
final InputStream input = new FileInputStream(file);
try {
    return IOUtils.toByteArray(input);
} finally {
    input.close();
}

{code}
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to