[JIRA] [ssh] (JENKINS-22938) SSH slave connections die after the slave outputs 4MB of stderr, usually during findbugs analysis

Mon, 19 May 2014 09:45:03 -0700

Code changed in jenkins
User: Stephen Connolly
Path:
src/com/trilead/ssh2/channel/Channel.java
http://jenkins-ci.org/commit/trilead-ssh2/5811ddd7ae15670a4f9ad345352613b3f2f2db97
Log:
JENKINS-22938 SSH slave connections die after the slave outputs 4MB of stderr, usually during findbugs analysis

The fix for JENKINS-18836, JENKINS-18879, JENKINS-19619 was incorrect in its analysis.

  • There is no call to getChannelData() on the new code path, so thus you cannot have two calls of freeupWindow()
  • The problem with the original call to freeupWindow() is that it is on the receiver thread. You should not mix the responsibilities. Blocking the receiver thread to send a message will negatively impact performance and connection stability.
  • The correct solution is to push the freeupWindow onto the async queue thus the ACK gets sent and the purity of the receiving thread can be maintained.
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to