[JIRA] [core] (JENKINS-18065) AbstractLazyLoadRunMap.iterator() calls .all()

Fri, 11 Jul 2014 11:44:34 -0700

The problematic part is this:

    at jenkins.model.lazy.AbstractLazyLoadRunMap.all(AbstractLazyLoadRunMap.java:617)
    at jenkins.model.lazy.AbstractLazyLoadRunMap.entrySet(AbstractLazyLoadRunMap.java:277)
    at java.util.AbstractMap$2$1.<init>(Unknown Source)
    at java.util.AbstractMap$2.iterator(Unknown Source)
    at hudson.util.RunList.iterator(RunList.java:97)



In looking at the code, what's going on is that RunList calls job.getBuilds():





    public RunList(View view) {// this is a type unsafe operation
        Set<Job> jobs = new HashSet<Job>();
        for (TopLevelItem item : view.getItems())
            jobs.addAll(item.getAllJobs());

        List<Iterable<R>> runLists = new ArrayList<Iterable<R>>();
        for (Job job : jobs) {
            runLists.add(job.getBuilds());
        }
        this.base = combine(runLists);
    }






and job.getBuilds() does this:





    public RunList<RunT> getBuilds() {
        return RunList.fromRuns(_getRuns().values());
    }






... which results in RunMap.values() which is implemented by AbstractMap, which calls ALLRM.entrySet(), that calls all().



ALLRM.entrySet() impl must be smarter, or job.getBuilds() need to avoid calling values().
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to