Mark Waite commented on New Feature JENKINS-23860

JENKINS-21248 was not rejected as an enhancement request, it was rejected because the author of the enhancement refused to implement it so that the enhancement would be maintainable in future versions. That is the submitter's right, as part of an open source project, but it is also the maintainer's right to reject changes which make the plugin more difficult to maintain.

The git plugin and the git client plugin are installed in over 30000 Jenkins installations. We're trying to be very careful that changes accepted into the git client plugin and the git plugin will not break those 30000+ installations and will be maintainable and extensible for future versions.

The tight coupling which would be created between a "command line arguments" field for every git command in the git client plugin and the UI would make the implementation even more tightly attached to the command line git implementation. The JGit implementation (also in the git client plugin) would be unable to adapt to those command line arguments, as would any future alternate implementations (like a libgit2 based implementation).

If you'd like to join the efforts to improve the git-client-plugin, you're encouraged to join the development community and submit "pull requests". I'd love to see your proposals, and particularly in submodules we could use many more unit tests to confirm the plugin is behaving as expected.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to