Change By: Tom FENNELLY (08/Aug/14 10:48 AM)
Description: This will help us eliminate the use of file names for icons and instead move to a CSS class spec type model.

I think this should be done by adding a new interface in the icons-set module (located in the icon-shim plugin repo https://github.com/jenkinsci/icon-shim-plugin). This will allow plugins maintain backward compatibility with older versions of Jenkins core.

e.g.
{code:java} 
interface IconSpec {
    String getIconClassName();
}
{code}

Then... plugin extension points that implement/extend Action/ManagementLink can also implement this interface.

Then... jelly scripts that use 'iconFileName' (e.g.
 
core/src/main/resources/jenkins/model/Jenkins/manage.jelly) can be changed to use 'iconClassName' , falling back to 'iconFileName' if 'iconClassName' not available .
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to