[JIRA] [ghprb] (JENKINS-24446) When using triggerOnly - only pull requests from whitelisted members are triggered

[memp...@machzwo.de (JIRA)]

Mem phisch created JENKINS-24446 When using triggerOnly - only pull requests from whitelisted members are triggered Issue Type: Bug Assignee: Honza Brázdil Components: ghprb Created: 26/Aug/14 1:21 PM Description: As the Topic says. 1. We are using the trigger only feature. 2. All members of the xbmc foundation are whitelisted for triggeronly 3. When a member now triggers by commenting the triggerphrase on a PR it only works when the PR was done by a whitelisted/team member This line of code is the problem: https://github.com/jenkinsci/ghprb-plugin/blob/master/src/main/java/org/jenkinsci/plugins/ghprb/GhprbPullRequest.java#L290 It checks the "accepted" flag which is only true if the author of the PR was whitelisted. It is set to true here: https://github.com/jenkinsci/ghprb-plugin/blob/master/src/main/java/org/jenkinsci/plugins/ghprb/GhprbPullRequest.java#L77 IMO the "accepted" flag shouldn't be checked at all in the triggeronly scenario. Its enough that the commenter is whitelisted. Environment: Jenkins 1.571 GHPRB 1.14-3 Project: Jenkins Priority: Major Reporter: Mem phisch

This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira

--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.