[JIRA] [gerrit] (JENKINS-24445) Retriggering builds via the "Manual Trigger" feature of the Gerrit Trigger Plugin causes wrong verification

Thu, 28 Aug 2014 21:24:33 -0700

rin_ne commented on Bug JENKINS-24445

This is not critical issue since only caused in rare condition. But it would be critical if once happens.

From code, It is certain that gerrit-trigger runs under the below assumptions:

  1. A patchset-created event for a patchset in a change is generated only once
  2. Only one build is scheduled from a job triggered by a event.

The event instance generated by Gerrit event stream is different with the one generated by manual trigger. But object comparison by equals() is true. This fact breaks assumption #1.

If manual trigger happens while triggered job has running build triggered by Gerrit stream event, a job has 2 builds generated by the same event. This breaks assumption #2.

So when manual trigger happens, plugin behavior is already unstable. Unfortunately, result would be undefined.

Perhaps this is design issue. So this cannot be fixed easily with no plan.
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to