|
||||||||
|
This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira |
||||||||
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
The reset in the api.rb should actually prevent the above exception, since a Ruby Exception cannot be converted to a Java Exception (and passed to the Throwable parameter of the sever logger method).
BUT this should not fix the actual problem. If you have a project that determines its branch from a parameter (that isn't a plain string parameter) an exception will be thrown. We currently have problem with this behavior, since we have some jobs that should be triggered automatically, and some that should be started by selecting a git tag. The git tag (which isn't a string parameter) causes the plugin to fail, so our development jobs, that should be triggered automatically will never run.
We currently modified the plugin, by commenting the line https://github.com/jenkinsci/gitlab-hook-plugin/blob/master/models/values/project.rb#L80.
That is not a real solution to this problem. I think the `get_branch_name_parameter` method ( https://github.com/jenkinsci/gitlab-hook-plugin/blob/master/models/values/project.rb#L46 ) should not throw an exception for not string parameters, but just log that out, and ignore that job (treat it as not matching and not causing a build for it).
Since I am not a Ruby programmer, I don't feel able to send a pull request for that. Might anyone of you fix that?
Thanks, Tim