|
||||||||
|
This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira |
||||||||
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
For more options, visit https://groups.google.com/d/optout.
Code changed in jenkins
User: Matt Moore
Path:
samples/android-emulator/.jenkins.yaml
samples/with-param/.jenkins.yaml
src/main/java/com/google/jenkins/plugins/dsl/tag/KeyYamlTransformProvider.java
src/main/java/com/google/jenkins/plugins/dsl/util/JsonToYaml.java
src/test/java/com/google/jenkins/plugins/dsl/YamlDecoratorTest.java
src/test/java/com/google/jenkins/plugins/dsl/tag/DisplayNameYamlTransformProviderTest.java
src/test/java/com/google/jenkins/plugins/dsl/tag/KeyYamlTransformProviderTest.java
src/test/java/com/google/jenkins/plugins/dsl/util/JsonToYamlTest.java
src/test/java/goodbye/World.java
src/test/java/hello/World.java
src/test/resources/com/google/jenkins/plugins/dsl/param.yaml
src/test/resources/com/google/jenkins/plugins/dsl/tag/complex-by-name.json
src/test/resources/com/google/jenkins/plugins/dsl/tag/complex-by-name.yaml
src/test/resources/com/google/jenkins/plugins/dsl/tag/key.json
src/test/resources/com/google/jenkins/plugins/dsl/tag/key.yaml
http://jenkins-ci.org/commit/yaml-project-plugin/61244d06d11a130cb7d1b89f3c35e0e210cfddef
Log:
This change addresses JENKINS-25096.
=== Problem ===
When Jenkins submits certain types of form elements, such as BuildWrapper or JobProperties, it does so in a way that each kind is unique.
The way it does this is by submitting such elements with the type (digested) as the KEY in that level of the map, e.g.
"com-example-Foo": { ... }
The digestion that occurs here inhibits our ability to translate these as "!by-name My foo: { ... }".
=== Solution ===
I thought about solving this by introducing "!key-by-name", which just did the right thing for "!by-name", however, this blocks @YamlTag from doing the right thing on annotated classes.
Instead, I introduced a new YamlTransformProvider, which walks all of the other providers composing a new transform with them to create: "!key:{old tag}".
So now, you can specify "!key:by-name My foo", but also "!key:foo" with no additional annotation.