[JIRA] [perforce-plugin] (JENKINS-25559) Missing hash in client names with EXECUTOR_NUMBER leads to workspace collisions

Wed, 12 Nov 2014 07:34:24 -0800

If PerforceSCM fails to resolve the client name (it happens due to unresolved EXECUTOR_NUMBER), it fall-backs to a default value without a hash.
Currently, I'm working on this issue. The proper way would be to limit the number of nested recursions in buildEnvVars() by 2 instead of 1 (current implementation)

private String getEffectiveClientName(@Nonnull AbstractBuild build, @CheckForNull Map<String,String> env)
throws ParameterSubstitutionException, InterruptedException {
Node buildNode = build.getBuiltOn();
FilePath workspace = build.getWorkspace();
String effectiveP4Client = this.p4Client;
try

Unknown macro: { effectiveP4Client = getEffectiveClientName(effectiveP4Client, build); }
catch (Exception e)
Unknown macro: { new StreamTaskListener(System.out).getLogger().println( "Could not get effective client name}

effectiveP4Client = MacroStringHelper.substituteParameters(effectiveP4Client, this, build, env);
return effectiveP4Client;
}
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to