[JIRA] [git-plugin] (JENKINS-25353) Git operations fail due to "dead", but lingering lock file

Wed, 03 Dec 2014 00:34:10 -0800

InterruptedException is catched in method org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(ArgumentListBuilder, File, EnvVars, Integer)
There it is wrapped in GitException to add some message. Nevertheless, the method is declared to throw InterruptedException. So, it whould be no problem to make the following change 

diff --git a/src/main/java/org/jenkinsci/plugins/gitclient/CliGitAPIImpl.java b/src/main/java/org/jenkinsci/plugins/gitclient/CliGitAPIImpl.java
index c55806e..3fdd2ca 100644
--- a/src/main/java/org/jenkinsci/plugins/gitclient/CliGitAPIImpl.java
+++ b/src/main/java/org/jenkinsci/plugins/gitclient/CliGitAPIImpl.java
@@ -1447,6 +1447,8 @@ public class CliGitAPIImpl extends LegacyCompatibleGitAPIImpl {
             throw e;
         } catch (IOException e) {
             throw new GitException("Error performing command: " + command, e);
+        } catch (InterruptedException e) {
+            throw e;
         } catch (Throwable t) {
             throw new GitException("Error performing git command", t);
         }

Do you prefer this approach instead of creating separate exception class?
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to