Issue Type: Improvement Improvement
Assignee: Nicolas De Loof
Components: git-plugin
Created: 07/Jan/15 6:27 AM
Description:

When a commit hook triggers a Jenkins build using the git-plugin's REST API, the cause of this is a CommitHookCause. However, this Cause doesn't extend SCMTriggerCause.

This means that plugins which have an option to do things like ignore SCM-triggered changes (eg the sonar plugin) don't treat these triggers correctly.

I'm happy to submit a pull request, but I'm not sure if there are any subtle/unwanted side effects from this. I saw a similar request (JENKINS-15823) for the gerrit jenkins plugin.

(Note that some plugins will still not detect this - the sonar plugin uses "SCMTrigger.SCMTriggerCause.class.isInstance(cause)" and so is fine with subclasses, but eg the run condition plugin does a string comparison on the class name, so will still not see this properly)

Project: Jenkins
Priority: Minor Minor
Reporter: Bradley Baetz
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to