[JIRA] [core] (JENKINS-26380) Deadlock between Queue and Jenkins model

[bernie.schelb...@ausregistry.com.au (JIRA)]

Bernie Schelberg commented on JENKINS-26380 Deadlock between Queue and Jenkins model This has been introduced in this commit: https://github.com/jenkinsci/jenkins/commit/7335916f I'd like to submit a PR, but I'm not sure about the best way to fix this. I've removed the lock on the Queue in CloudRetentionStrategy in my local repo, and have been running that code for 3 days without a deadlock occurring. The commit message implies that more refactoring is to come around Queue locking, so I don't want to interfere with that plan. I've seen that other deadlocks involving RetentionStrategy.check() have been fixed by converting the synchronized method to using a ReentrantLock. But the ones I've seen don't do anything if the lock cannot be obtained. In this case, I don't think the methods should return without doing anything. So, some of the ideas I have: Remove the Queue lock in CloudRetentionStrategy.check() Lock the Queue in AbstractCloudSlave.terminate() (so that the Queue is locked before calling Jenkins.removeNode()) Lock the Jenkins model in CloudRetentionStrategy.check() Are there any other options? If not, which would be the best approach?

This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira

--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.