|
||||||||
|
This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira |
||||||||
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
For more options, visit https://groups.google.com/d/optout.
Thanks for the pull request!
On the GitHub pull request page, you wrote that you ended up taking the proxy configuration from the JVM, which is to say, from the system property "http.proxy", and not from the Jenkins :Manage Plugins, Advanced" page. However if I understand correctly, this should come down to the same result, as the help bubble on that page says "The value you submit here will be set as http.proxyHost system property". It also appears in some wiki pages. So your change should be fine.
Nevertheless, I did a quick search, and it seems the convention is to go through Jenkins by using "jenkins.model.Jenkins.getInstance().proxy", as seen in this example in the async-http-client plugin and other examples, so this might be more appropriate?
This plugin is my only contribution to Jenkins so far, so I am not very aware of its ecosystem. Maybe Daniel can clarify what's the recommended way.