|
||||||||
|
This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira |
||||||||
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
For more options, visit https://groups.google.com/d/optout.
Okay, disabling strategies one by one makes more sense, my misunderstanding.
the SCM Sync status footer
I was wrong, this doesn't seem to be affected (I was sloppy reading footer.jelly yesterday).
detailed commit messages
Since the job strategy would be disabled and the manual strategy used instead, the commit messages would be Modification on configuration(s) / Item renamed / File hierarchy deleted instead of Job XYZ configuration updated / Job XYZ hierarchy renamed from ABC to DEF / Job XYZ hierarchy deleted. It makes it less clear what's been changed when skimming the changes in an scm browser, but it's not a blocker.
the ability to customize commit messages
The decorateOnsubmitForm logic in footer.jelly is only shown if the current page matches a PageMatcher from a strategy. If the job strategy is disabled and the manual strategy used instead, I assume there will be no PageMatcher matching URIs like view/All/job/myjob/configure, so the user won't be given an opportunity to provide a custom commit message when configuring jobs. Not a big issue.
So, the tradeoff would be improved performance against less clarity in the SCM history. I think it's an acceptable tradeoff, but the best would be if I could keep both of course.![]()
By the way, I found a bug in the PageMatcher regexp in JobConfigScmSyncStrategy. I'll post a separate JIRA issue for that.