[JIRA] [swarm-plugin] (JENKINS-26558) createSlave Node name collision avoidance creates dead nodes

Mon, 27 Apr 2015 12:29:36 -0700

Code changed in jenkins
User: Stephen Connolly
Path:
client/src/main/java/hudson/plugins/swarm/Client.java
client/src/main/java/hudson/plugins/swarm/SwarmClient.java
plugin/src/main/java/hudson/plugins/swarm/PluginImpl.java
http://jenkins-ci.org/commit/swarm-plugin/ab37bc84eb9639888f3a66c68a9b1536c5882c88
Log:
[FIXED JENKINS-26558] Clients should provide a unique ID to be used for name collision avoidance

  • The current name collision avoidance uses the requests address, which could very likely be the same for all clients
    as they could be being routed through a HTTP proxy (or two) so that is not a good disambiguator
  • We use a digest of the client's interfaces and MAC addresses and the remoteFSRoot to try and give a consistent ID
  • We ALWAYS append the ID if we have it as otherwise during reconnect the slaves with the same name will shuffle around
    which defeats a lot of the login that Jenkins has internally based on slaves having a consistent name
  • In the event of legacy clients that do not have the ID we will let them connect with their name as long as there
    is no online slave with that name. This does mean that where there are multiple legacy swarm clients with the
    same name, only one can be on-line at any moment in time, but that is an improvement on the current where
    once a shuffle starts, none can stay on-line
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to