This is so good. :)

The pre and post diffs looked right, and the new UI and functionality gives 
me everything that I was hoping for.

I'm going to remove the "discover pull requests from [everywhere]" 
behaviors and select "Only branches that are also filed as PRs" on 
production as soon as possible.

Michael Neale mentioned that one issue he had seen "does look better now 
with the new version." I used the plugin versions that Stephen originally 
posted on June 20, but I take Michael's comment to mean there might be 
newer versions. Please make this irrelevant by issuing release versions of 
these plugins this week. :)

Thanks a ton!
-KB

On Friday, June 23, 2017 at 12:45:44 PM UTC-4, Stephen Connolly wrote:
>
>
>
> On 23 June 2017 at 17:24, Mark Waite <mark.ea...@gmail.com <javascript:>> 
> wrote:
>
>> I see duplicate entries in the "Add' configuration of the Bitbucket 
>> source for "Checkout over ssh".  Let me know if you need steps to see that.
>>
>
> Shouldn't... may just be a bug in the drop down populator when you have 
> GitHub and Bitbucket
>  
>
>>
>> I also wonder if the text "General", "Git" and "Bitbucket" should be 
>> italicized, or bold, or separated with dashes, or something, so that the 
>> user has a concept that things will be appearing under them.  They seem to 
>> be standard text currently, and it wasn't obvious to me that they were 
>> categories into which settings would be placed.
>>
>
> Cannot style the drop-down menu without significant JS changes that risk 
> affecting form binding.
>  
>
>>
>> Mark Waite
>>
>>
>> On Friday, June 23, 2017 at 9:58:52 AM UTC-6, Mark Waite wrote:
>>>
>>> The UI experience has been great for me in the two or three places where 
>>> I've used it.  I was a little surprised (and pleased) with the adaptation 
>>> that the local branch setting is now a toggle.  I think that's the right 
>>> approach, since (as far as I can tell) that is the 99% use case.
>>>
>>> Earlier I reported an NPE when configuring a multi-branch pipeline that 
>>> uses GitHub as source instead of Git as source.  The NPE was resolved by 
>>> removing the multiple-scms plugin.  Unfortunately, the 404 is still there, 
>>> along with a stack trace that starts with this:
>>>
>>> Jun 23, 2017 9:51:38 AM hudson.ExpressionFactory2$JexlExpression evaluate
>>> WARNING: Caught exception evaluating: 
>>> descriptor.calcFillSettings(field,attrs) in 
>>> /job/Git-Client-Folder/job/git-client-pipeline-github/configure. Reason: 
>>> java.lang.IllegalStateException: class 
>>> org.jenkinsci.plugins.github_branch_source.GitHubSCMSource$DescriptorImpl 
>>> doesn't have the doFillCredentialsIdItems method for filling a drop-down 
>>> list
>>> java.lang.IllegalStateException: class 
>>> org.jenkinsci.plugins.github_branch_source.GitHubSCMSource$DescriptorImpl 
>>> doesn't have the doFillCredentialsIdItems method for filling a drop-down 
>>> list
>>> at hudson.model.Descriptor.calcFillSettings(Descriptor.java:412)
>>> at sun.reflect.GeneratedMethodAccessor578.invoke(Unknown Source)
>>> at 
>>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>>> at java.lang.reflect.Method.invoke(Method.java:498)
>>> at 
>>> org.apache.commons.jexl.util.introspection.UberspectImpl$VelMethodImpl.invoke(UberspectImpl.java:258)
>>> at org.apache.commons.jexl.parser.ASTMethod.execute(ASTMethod.java:104)
>>> at 
>>> org.apache.commons.jexl.parser.ASTReference.execute(ASTReference.java:83)
>>> at 
>>> org.apache.commons.jexl.parser.ASTReference.value(ASTReference.java:57)
>>> at 
>>> org.apache.commons.jexl.parser.ASTReferenceExpression.value(ASTReferenceExpression.java:51)
>>> at 
>>> org.apache.commons.jexl.ExpressionImpl.evaluate(ExpressionImpl.java:80)
>>> at 
>>> hudson.ExpressionFactory2$JexlExpression.evaluate(ExpressionFactory2.java:74)
>>> at 
>>> org.apache.commons.jelly.parser.EscapingExpression.evaluate(EscapingExpression.java:24)
>>> at 
>>> org.apache.commons.jelly.impl.ExpressionScript.run(ExpressionScript.java:66)
>>> at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95)
>>>
>>> I'm not sure how to provide a repeatable condition for that bug yet, but 
>>> wanted to alert you about it.  I won't investigate further on it until 
>>> after the end of the working day today.
>>>
>>> Mark Waite
>>>
>>> On Friday, June 23, 2017 at 7:32:54 AM UTC-6, Stephen Connolly wrote:
>>>>
>>>> How do you find the new UI compared with the previous one?
>>>>
>>>> -- 
>> You received this message because you are subscribed to the Google Groups 
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to jenkinsci-de...@googlegroups.com <javascript:>.
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/jenkinsci-dev/c2e110d7-f929-461d-8595-273e8e543d89%40googlegroups.com
>>  
>> <https://groups.google.com/d/msgid/jenkinsci-dev/c2e110d7-f929-461d-8595-273e8e543d89%40googlegroups.com?utm_medium=email&utm_source=footer>
>> .
>>
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-users+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-users/2bc996a5-b2d6-4c22-884a-a7a026cc9472%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to