Hi Alexander, Glad you’re giving a go with the “Gerrit Code Review” plugin and hope you like it :-)
See my feedback below. > On 9 Dec 2020, at 12:43, Alexander Vladimirovich <[email protected]> wrote: > > Good day! > I try to integrate Jenkins with Gerrit and use 'Gerrit code review' plugin > for it. > F.e. i have test project with 3 branches: > <image.png> > > Scan Multibranch Pipeline Log without filter by pending checks : > > Started > [Ср дек 09 11:12:03 UTC 2020] Starting branch indexing... > > git rev-parse --is-inside-work-tree # timeout=10 > Setting origin to https://gerrit.office.sprut.ru/a/test/pipeline2 > <https://gerrit.office.sprut.ru/a/test/pipeline2> > > git config remote.origin.url > > https://gerrit.office.sprut.ru/a/test/pipeline2 > > <https://gerrit.office.sprut.ru/a/test/pipeline2> # timeout=10 > Fetching origin... > Looking for open changes with query 'p:test/pipeline2 status:open -age:24w ' > ... > Fetching upstream changes from origin > > git --version # timeout=10 > > git --version # 'git version 2.25.1' > > git config --get remote.origin.url # timeout=10 > using GIT_ASKPASS to set credentials jenkins for gerrit account , register at > AD - login password > > git fetch --tags --force --progress -- origin > > +refs/heads/*:refs/remotes/origin/* > > refs/changes/52/1852/2:refs/remotes/origin/52/1852/2 > > refs/changes/53/1753/1:refs/remotes/origin/53/1753/1 # timeout=10 > using GIT_ASKPASS to set credentials jenkins for gerrit account , register at > AD - login password > > git ls-remote --symref -- https://gerrit.office.sprut.ru/a/test/pipeline2 > > <https://gerrit.office.sprut.ru/a/test/pipeline2> # timeout=10 > > git rev-parse --is-inside-work-tree # timeout=10 > Setting origin to https://gerrit.office.sprut.ru/a/test/pipeline2 > <https://gerrit.office.sprut.ru/a/test/pipeline2> > > git config remote.origin.url > > https://gerrit.office.sprut.ru/a/test/pipeline2 > > <https://gerrit.office.sprut.ru/a/test/pipeline2> # timeout=10 > Fetching & pruning origin... > Looking for open changes with query 'p:test/pipeline2 status:open -age:24w ' > ... > Fetching upstream changes from origin > > git --version # timeout=10 > > git --version # 'git version 2.25.1' > > git config --get remote.origin.url # timeout=10 > using GIT_ASKPASS to set credentials jenkins for gerrit account , register at > AD - login password > > git fetch --tags --force --progress --prune -- origin > > +refs/heads/*:refs/remotes/origin/* > > refs/changes/52/1852/2:refs/remotes/origin/52/1852/2 > > refs/changes/53/1753/1:refs/remotes/origin/53/1753/1 # timeout=10 > Seen branch in repository origin/52/1852/2 > Seen branch in repository origin/53/1753/1 > Seen branch in repository origin/master > Seen branch in repository origin/notmaster > Seen branch in repository origin/release > Seen 5 remote branches > Checking 5 branches ... > Filtered 5 branches ... > Checking branch master > ‘Jenkinsfile.jenkins’ found > master meets the criteria > > git rev-parse --is-inside-work-tree # timeout=10 > Setting origin to https://gerrit.office.sprut.ru/a/test/pipeline2 > <https://gerrit.office.sprut.ru/a/test/pipeline2> > > git config remote.origin.url > > https://gerrit.office.sprut.ru/a/test/pipeline2 > > <https://gerrit.office.sprut.ru/a/test/pipeline2> # timeout=10 > Fetching origin... > Looking for open changes with query 'p:test/pipeline2 status:open -age:24w ' > ... > Fetching upstream changes from origin > > git --version # timeout=10 > > git --version # 'git version 2.25.1' > > git config --get remote.origin.url # timeout=10 > using GIT_ASKPASS to set credentials jenkins for gerrit account , register at > AD - login password > > git fetch --tags --force --progress -- origin > > +refs/heads/master:refs/remotes/origin/master # timeout=10 > No changes detected: master (still at > 76848b58bac543ab1b49fd88099bf62ab18cc32f) > ‘Jenkinsfile.jenkins’ found > Met criteria > > git rev-parse --is-inside-work-tree # timeout=10 > Setting origin to https://gerrit.office.sprut.ru/a/test/pipeline2 > <https://gerrit.office.sprut.ru/a/test/pipeline2> > > git config remote.origin.url > > https://gerrit.office.sprut.ru/a/test/pipeline2 > > <https://gerrit.office.sprut.ru/a/test/pipeline2> # timeout=10 > Fetching origin... > Looking for open changes with query 'p:test/pipeline2 status:open -age:24w ' > ... > Fetching upstream changes from origin > > git --version # timeout=10 > > git --version # 'git version 2.25.1' > > git config --get remote.origin.url # timeout=10 > using GIT_ASKPASS to set credentials jenkins for gerrit account , register at > AD - login password > > git fetch --tags --force --progress -- origin > > refs/changes/53/1753/1:refs/remotes/origin/53/1753/1 # timeout=10 > No changes detected: 53/1753/1 (still at > 7bcf364020c3405aa91b2e2c8f7adab75e91a1b1) > Checking branch notmaster > ‘Jenkinsfile.jenkins’ found > notmaster meets the criteria > > git rev-parse --is-inside-work-tree # timeout=10 > Setting origin to https://gerrit.office.sprut.ru/a/test/pipeline2 > <https://gerrit.office.sprut.ru/a/test/pipeline2> > > git config remote.origin.url > > https://gerrit.office.sprut.ru/a/test/pipeline2 > > <https://gerrit.office.sprut.ru/a/test/pipeline2> # timeout=10 > Fetching origin... > Looking for open changes with query 'p:test/pipeline2 status:open -age:24w ' > ... > Fetching upstream changes from origin > > git --version # timeout=10 > > git --version # 'git version 2.25.1' > > git config --get remote.origin.url # timeout=10 > using GIT_ASKPASS to set credentials jenkins for gerrit account , register at > AD - login password > > git fetch --tags --force --progress -- origin > > +refs/heads/notmaster:refs/remotes/origin/notmaster # timeout=10 > No changes detected: notmaster (still at > 76848b58bac543ab1b49fd88099bf62ab18cc32f) > ‘Jenkinsfile.jenkins’ found > Met criteria > > git rev-parse --is-inside-work-tree # timeout=10 > Setting origin to https://gerrit.office.sprut.ru/a/test/pipeline2 > <https://gerrit.office.sprut.ru/a/test/pipeline2> > > git config remote.origin.url > > https://gerrit.office.sprut.ru/a/test/pipeline2 > > <https://gerrit.office.sprut.ru/a/test/pipeline2> # timeout=10 > Fetching origin... > Looking for open changes with query 'p:test/pipeline2 status:open -age:24w ' > ... > Fetching upstream changes from origin > > git --version # timeout=10 > > git --version # 'git version 2.25.1' > > git config --get remote.origin.url # timeout=10 > using GIT_ASKPASS to set credentials jenkins for gerrit account , register at > AD - login password > > git fetch --tags --force --progress -- origin > > refs/changes/52/1852/2:refs/remotes/origin/52/1852/2 # timeout=10 > No changes detected: 52/1852/2 (still at > f021817b26b6cde8c83a1186b18bc5231e3bd228) > Checking branch release > ‘Jenkinsfile.jenkins’ found > release meets the criteria > > git rev-parse --is-inside-work-tree # timeout=10 > Setting origin to https://gerrit.office.sprut.ru/a/test/pipeline2 > <https://gerrit.office.sprut.ru/a/test/pipeline2> > > git config remote.origin.url > > https://gerrit.office.sprut.ru/a/test/pipeline2 > > <https://gerrit.office.sprut.ru/a/test/pipeline2> # timeout=10 > Fetching origin... > Looking for open changes with query 'p:test/pipeline2 status:open -age:24w ' > ... > Fetching upstream changes from origin > > git --version # timeout=10 > > git --version # 'git version 2.25.1' > > git config --get remote.origin.url # timeout=10 > using GIT_ASKPASS to set credentials jenkins for gerrit account , register at > AD - login password > > git fetch --tags --force --progress -- origin > > +refs/heads/release:refs/remotes/origin/release # timeout=10 > No changes detected: release (still at > 73cce37670899c7e10fd1aa4f59d3bb70c1f393d) > Processed 0 branches > Processed 0 changes > [Ср дек 09 11:12:05 UTC 2020] Finished branch indexing. Indexing took 1,9 > секунды > Finished: SUCCESS > > But when i add filter by pending checks, all branches are disappear, changes > are displayed and marked as 'Scheduled' in Gerrit. > <unnamed.png> > Scan Multibranch Pipeline Log: > Started > [Ср дек 09 11:13:53 UTC 2020] Starting branch indexing... > > git rev-parse --is-inside-work-tree # timeout=10 > Setting origin to https://gerrit.office.sprut.ru/a/test/pipeline2 > <https://gerrit.office.sprut.ru/a/test/pipeline2> > > git config remote.origin.url > > https://gerrit.office.sprut.ru/a/test/pipeline2 > > <https://gerrit.office.sprut.ru/a/test/pipeline2> # timeout=10 > Fetching origin... > Looking for open changes with query 'p:test/pipeline2 status:open -age:24w ' > ... > Fetching upstream changes from origin > > git --version # timeout=10 > > git --version # 'git version 2.25.1' > > git config --get remote.origin.url # timeout=10 > using GIT_ASKPASS to set credentials jenkins for gerrit account , register at > AD - login password > > git fetch --tags --force --progress -- origin > > +refs/heads/*:refs/remotes/origin/* > > refs/changes/52/1852/2:refs/remotes/origin/52/1852/2 > > refs/changes/53/1753/1:refs/remotes/origin/53/1753/1 # timeout=10 > using GIT_ASKPASS to set credentials jenkins for gerrit account , register at > AD - login password > > git ls-remote --symref -- https://gerrit.office.sprut.ru/a/test/pipeline2 > > <https://gerrit.office.sprut.ru/a/test/pipeline2> # timeout=10 > > git rev-parse --is-inside-work-tree # timeout=10 > Setting origin to https://gerrit.office.sprut.ru/a/test/pipeline2 > <https://gerrit.office.sprut.ru/a/test/pipeline2> > > git config remote.origin.url > > https://gerrit.office.sprut.ru/a/test/pipeline2 > > <https://gerrit.office.sprut.ru/a/test/pipeline2> # timeout=10 > Fetching & pruning origin... > Looking for open changes with query 'p:test/pipeline2 status:open -age:24w ' > ... > Fetching upstream changes from origin > > git --version # timeout=10 > > git --version # 'git version 2.25.1' > > git config --get remote.origin.url # timeout=10 > using GIT_ASKPASS to set credentials jenkins for gerrit account , register at > AD - login password > > git fetch --tags --force --progress --prune -- origin > > +refs/heads/*:refs/remotes/origin/* > > refs/changes/52/1852/2:refs/remotes/origin/52/1852/2 > > refs/changes/53/1753/1:refs/remotes/origin/53/1753/1 # timeout=10 > Seen branch in repository origin/52/1852/2 > Seen branch in repository origin/53/1753/1 > Seen branch in repository origin/master > Seen branch in repository origin/notmaster > Seen branch in repository origin/release > Seen 5 remote branches > Checking 5 branches ... > Filtered 5 branches ... > ‘Jenkinsfile.jenkins’ found > Met criteria > Updated the status of check testplugin:test1 for patchset 1753/1 to SCHEDULED. > > git rev-parse --is-inside-work-tree # timeout=10 > Setting origin to https://gerrit.office.sprut.ru/a/test/pipeline2 > <https://gerrit.office.sprut.ru/a/test/pipeline2> > > git config remote.origin.url > > https://gerrit.office.sprut.ru/a/test/pipeline2 > > <https://gerrit.office.sprut.ru/a/test/pipeline2> # timeout=10 > Fetching origin... > Looking for open changes with query 'p:test/pipeline2 status:open -age:24w ' > ... > Fetching upstream changes from origin > > git --version # timeout=10 > > git --version # 'git version 2.25.1' > > git config --get remote.origin.url # timeout=10 > using GIT_ASKPASS to set credentials jenkins for gerrit account , register at > AD - login password > > git fetch --tags --force --progress -- origin > > refs/changes/53/1753/1:refs/remotes/origin/53/1753/1 # timeout=10 > Changes detected: 53/1753/1 (7bcf364020c3405aa91b2e2c8f7adab75e91a1b1 → > 7bcf364020c3405aa91b2e2c8f7adab75e91a1b1) > Scheduled build for branch: 53/1753/1 > Processed 0 branches > Processed 0 changes > [Ср дек 09 11:13:54 UTC 2020] Finished branch indexing. Indexing took 1 > секунда > Evaluating orphaned items in testMP > Will remove 52/1852/2 > Will remove release > Will remove notmaster > Will remove master > Finished: SUCCESS Yes, that is done by design. > > And at the next scan all changes are also not displayed at the 'Status'. > Scan Multibranch Pipeline Log: > Started > [Ср дек 09 11:14:53 UTC 2020] Starting branch indexing... > > git rev-parse --is-inside-work-tree # timeout=10 > Setting origin to https://gerrit.office.sprut.ru/a/test/pipeline2 > <https://gerrit.office.sprut.ru/a/test/pipeline2> > > git config remote.origin.url > > https://gerrit.office.sprut.ru/a/test/pipeline2 > > <https://gerrit.office.sprut.ru/a/test/pipeline2> # timeout=10 > Fetching origin... > Looking for open changes with query 'p:test/pipeline2 status:open -age:24w ' > ... > Fetching upstream changes from origin > > git --version # timeout=10 > > git --version # 'git version 2.25.1' > > git config --get remote.origin.url # timeout=10 > using GIT_ASKPASS to set credentials jenkins for gerrit account , register at > AD - login password > > git fetch --tags --force --progress -- origin > > +refs/heads/*:refs/remotes/origin/* > > refs/changes/52/1852/2:refs/remotes/origin/52/1852/2 > > refs/changes/53/1753/1:refs/remotes/origin/53/1753/1 # timeout=10 > using GIT_ASKPASS to set credentials jenkins for gerrit account , register at > AD - login password > > git ls-remote --symref -- https://gerrit.office.sprut.ru/a/test/pipeline2 > > <https://gerrit.office.sprut.ru/a/test/pipeline2> # timeout=10 > > git rev-parse --is-inside-work-tree # timeout=10 > Setting origin to https://gerrit.office.sprut.ru/a/test/pipeline2 > <https://gerrit.office.sprut.ru/a/test/pipeline2> > > git config remote.origin.url > > https://gerrit.office.sprut.ru/a/test/pipeline2 > > <https://gerrit.office.sprut.ru/a/test/pipeline2> # timeout=10 > Fetching & pruning origin... > Looking for open changes with query 'p:test/pipeline2 status:open -age:24w ' > ... > Fetching upstream changes from origin > > git --version # timeout=10 > > git --version # 'git version 2.25.1' > > git config --get remote.origin.url # timeout=10 > using GIT_ASKPASS to set credentials jenkins for gerrit account , register at > AD - login password > > git fetch --tags --force --progress --prune -- origin > > +refs/heads/*:refs/remotes/origin/* > > refs/changes/52/1852/2:refs/remotes/origin/52/1852/2 > > refs/changes/53/1753/1:refs/remotes/origin/53/1753/1 # timeout=10 > Seen branch in repository origin/52/1852/2 > Seen branch in repository origin/53/1753/1 > Seen branch in repository origin/master > Seen branch in repository origin/notmaster > Seen branch in repository origin/release > Seen 5 remote branches > Checking 5 branches ... > Filtered 5 branches ... > Processed 0 branches > Processed 0 changes > [Ср дек 09 11:14:54 UTC 2020] Finished branch indexing. Indexing took 0,78 > секунд > Evaluating orphaned items in testMP > Will remove 53/1753/1 > Finished: SUCCESS > > Is it correct behaviour? When you leave Gerrit to drive the choice of what to build, then whatever you would put in the discovery mechanism will be filtered out by the ones that Gerrit requires to be checked. > I can't find detailed documentation for 'Filter by pending checks' option. The documentation is shown when you click the “?” Icon on the right side of the “Filter by Pending Checks” section. It says: "Provide a query string to search for pending checks. Depending on which mode was chosen, this either should be a checker-scheme or the UUID of a specific checker.” > I expected to see all branches and changes. Not if you filter by pending checks. > > I tried to debug this situation and found out that request.process() in > method processBranchRequest in class AbstactGerritSCASource.java generates > InterruptedException. Do you have the whole stack trace? Can you report an issue on Jira and attach the trace? > > Thanks in advance! Thank you for your feedback. Luca. > > Kind regards, > Alexander > > -- > You received this message because you are subscribed to the Google Groups > "Jenkins Users" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected] > <mailto:[email protected]>. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jenkinsci-users/6c92ee35-40e0-44ce-959b-58387c8d0f76n%40googlegroups.com > > <https://groups.google.com/d/msgid/jenkinsci-users/6c92ee35-40e0-44ce-959b-58387c8d0f76n%40googlegroups.com?utm_medium=email&utm_source=footer>. > <unnamed.png><image.png> -- You received this message because you are subscribed to the Google Groups "Jenkins Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-users/F4A2CC99-FC12-485E-9868-382180D7B280%40gmail.com.
