Hi,
--- Santiago Gala <[EMAIL PROTECTED]> wrote:
>
> Other thing that is misserably failing is that the way we apply
> skins
> interferes with the CSS applied, so the grey skin shows black text
> on
> black background for selected tab (under Mozilla at least). I think
> we
> should go either ofr a full CSS definition, thus using styles in
> the
> controls and controllers, or for a "conventional" skinning scheme,
> and
> stop using the CSS file.
>
Following on from that theme then,
I made changes all to add class= options. Thus the changes only
impact jetspeed/-tab.vm. I've taken the liberty of putting some
samples in the defaults.css too. Feel free to remove/amend/change as
you see fit.
diff -u's attached.
I've not removed any existing customisation - it will work if the css
entry is NOT used, eg blank - but the CSS stuff overrides the inline
settings, eg border=, bgcolor= etc if it set.
Thus it should be fully backwards compatible by removing/blanking out
the style entries in the default.css.
Regards,
Chris
=====
Need somewhere to Live in London - http://freeflats.com
__________________________________________________
Do You Yahoo!?
Get email alerts & NEW webcam video instant messaging with Yahoo! Messenger
http://im.yahoo.com
Index: WEB-INF/templates/vm/controls/html/jetspeed-tab.vm
===================================================================
RCS file:
/home/cvspublic/jakarta-jetspeed/webapp/WEB-INF/templates/vm/controls/html/jetspeed-tab.vm,v
retrieving revision 1.3
diff -u -r1.3 jetspeed-tab.vm
--- WEB-INF/templates/vm/controls/html/jetspeed-tab.vm 2001/09/04 11:12:15 1.3
+++ WEB-INF/templates/vm/controls/html/jetspeed-tab.vm 2001/09/04 16:36:47
@@ -2,10 +2,10 @@
#if ( ! $tabs )
#parse ("jetspeed.vm")
#else
-<table cellpadding="0" cellspacing="0" border="0" width="100%">
+<table cellpadding="0" cellspacing="0" border="0" width="100%" class="TabStyleClass">
<tr>
<td valign="top">
- <table align="left" cellspacing="0" border="0" cellpadding="0">
+ <table align="left" cellspacing="0" border="0" cellpadding="0"
+class="TabTitleStyleClass">
<tr width="100%">
#foreach ( $tab in $tabs )
#if ($tab.isSelected() )
@@ -37,18 +37,21 @@
</td>
</tr>
</table>
-<table cellspacing="0" width="100%" border="0" cellpadding="0">
+<table cellspacing="0" width="100%" border="0" cellpadding="0" class="TabStyleClass">
<tr><td height="2" bgcolor="$!{skin.HighlightBackgroundColor}"><img height="2"
width="2" src="images/dot.gif" /></td></tr>
<tr><td height="2" bgcolor="$!{skin.BackgroundColor}"><img height="2" width="2"
src="images/dot.gif" /></td></tr>
</table>
-<table bgcolor="$!{skin.BackgroundColor}" cellspacing="0" width="100%" border="0"
cellpadding="0">
+<table cellspacing="0" width="100%" border="0" cellpadding="0"
+class="TabStyleClass"><tr><td>
+<table bgcolor="$!{skin.BackgroundColor}" cellspacing="0" width="100%"
+ border="0" cellpadding="0" class="TabContentStyleClass">
<tr>
<td valign="top" width="100%">
$portlet.getContent($data)
</td>
</tr>
</table>
+</td></tr></table>
#end
#else
$portlet.getContent($data)
-#end
\ No newline at end of file
+#end
Index: WEB-INF/templates/vm/controls/html/jetspeed.vm
===================================================================
RCS file:
/home/cvspublic/jakarta-jetspeed/webapp/WEB-INF/templates/vm/controls/html/jetspeed.vm,v
retrieving revision 1.3
diff -u -r1.3 jetspeed.vm
--- WEB-INF/templates/vm/controls/html/jetspeed.vm 2001/09/04 11:12:15 1.3
+++ WEB-INF/templates/vm/controls/html/jetspeed.vm 2001/09/04 16:36:47
@@ -1,21 +1,22 @@
#if( ! $portlet.isClosed($data) )
-<table border="0" bgcolor="$!{skin.BackgroundColor}" cellpadding="0" cellspacing="0"
width="100%">
-<tr bgcolor="$!{skin.TitleBackgroundColor}">
- <td align="left" bgcolor="$!{skin.TitleBackgroundColor}" nowrap="true"
valign="middle" width="100%">
+<table border="0" bgcolor="$!{skin.BackgroundColor}" cellpadding="0" cellspacing="0"
+width="100%"
+ class="PortletStyleClass">
+<tr bgcolor="$!{skin.TitleBackgroundColor}" class="TitleStyleClass">
+ <td align="left" bgcolor="$!{skin.TitleBackgroundColor}"
+ nowrap="true" valign="middle" width="100%">
<b><font color="$!{skin.TitleTextColor}">$portlet.Title</font><b>
</td>
<td align="right" bgcolor="$!{skin.TitleBackgroundColor}" nowrap="true"
valign="middle">
#foreach ( $action in $actions )
<a href="${action.Link}" title="${action.Name}"><img
src="images/${action.Name}.gif" border="0"></a>
-
-
#end
</td>
</tr>
#if( ! $portlet.isMinimized($data) )
<tr>
<td colspan="2" align="center" valign="top" width="100%" >
- <table border="0" cellpadding="2" cellspacing="0" width="100%" align="center">
+ <table border="0" cellpadding="2" cellspacing="0"
+ width="100%" align="center" class="ContentStyleClass">
<tr>
<td>
$!portlet.getContent($data)
@@ -26,4 +27,4 @@
</tr>
#end
</table>
-#end
\ No newline at end of file
+#end
Index: css/default.css
===================================================================
RCS file: /home/cvspublic/jakarta-jetspeed/webapp/css/default.css,v
retrieving revision 1.2
diff -u -r1.2 default.css
--- css/default.css 2001/07/29 13:42:52 1.2
+++ css/default.css 2001/09/04 16:36:47
@@ -30,3 +30,37 @@
.MESSAGENEW:link {font-family: "Verdana"; font-size: 8pt; color:
NAVY;font-weight: bold}
.MESSAGENEW:visited {font-family: "Verdana"; font-size: 8pt; color:
BLACK;font-weight: bold}
+ .PortletStyleClass
+ {
+ padding: 1;
+ background-color: #AAAAAA;
+ border: thin gray solid;
+ }
+
+ .TabStyleClass
+ {
+ padding: 1;
+ }
+
+ .TitleStyleClass
+ {
+ text-transform: uppercase;
+ font-weight: bold;
+ }
+
+ .TabTitleStyleClass
+ {
+ background-color: #FFFFFF;
+ }
+
+ .ContentStyleClass
+ {
+ background-color: #FFFFFF;
+ border-top: thin gray solid;
+ }
+
+ .TabContentStyleClass
+ {
+ background-color: #FFFFFF;
+ }
+
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
