DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=4160>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=4160

The URL referenced by the WebPagePortlet is retrieved twice

[EMAIL PROTECTED] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED



------- Additional Comments From [EMAIL PROTECTED]  2001-10-18 09:58 -------
Note: this idiom (from the portlet code):

            htmlString = getURL( JetspeedDiskCache.getInstance()
                        .getEntry( config.getURL() ).getURL()  );

is wrong. People used to manage it to get a hold to a local URL from the cache,
bad practice.

If you want to use the cache, use

Reader rdr = JetspeedDiskCache.getInstance().getEntry( config.getURL()
).getReader();

if not, use new URL( config.getURL() )

Also, the usage of InputStreams in the rest of the code will break in a lot of
non Latin-1 pages.

This is the reason while the bug appears. The first line retrieves the file (if
it is not in the cache). Later, the URL is reopened again, thus retrieving it twice.

I don't like how this code is written:

- it reads the whole page into a string
- it will refetch the page for every request

But I will patch the portlet to avoid using the cache completely.

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to