Paul, I want to respond to this. I agree with your comment. This was my express intent in most of the fixes I've sent in. Being new to the code, and not a committer, and not fully understanding the big picture, I wanted to fix problems in Jetspeed with the least impact. I think that in the process, discussions about better API structuring within Jetspeed have commenced.
I'd rather re-write and re-structure to get the thing right. In the long run, and even in the medium run, I have found this to be the best approach. But there are definitely times and circumstances where a quick and specific fix makes the product better, now. It may not fix the architecture problem surfaced, but it makes it no worse. Speaking of which, the sorting fix I proposed for the BasePortletSet is one of these cases. Jetspeed is just wrong now, and this will fix it without making the architecture any worse than it is. It's a quick fix that will hold while we better understand and structure the bigger issues. - Glenn > -----Original Message----- > From: Paul Spencer [mailto:[EMAIL PROTECTED]] > Sent: Thursday, April 11, 2002 4:03 PM > To: Jetspeed Developers List > Subject: Re: Nominate Glenn Golden to Jetspeed Committer > > > +0 - Although I like the patches I have seen, in some cases > the patches > do not address the root problem, they just fix the results. > > Paul Spencer -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
