Since (I believe) this change, if a psml file has no mention at all of a <skin> for a portlet set, then it has *no* skin - all the skin references end up empty. For example, this psml which shows two portlets ends up with the title bars NOT COLORED, as the skin would have handled:
<?xml version="1.0" encoding="UTF-8"?> <portlets id="200" xmlns="http://www.apache.org/2000/02/CVS";> <metainfo> <title>The CHEF Portal</title> </metainfo> <entry id="100" parent="chef.motd"/> <entry id="101" parent="chef.intro"/> </portlets> Produces, for the title of "chef.motd": <td align="left" nowrap="true" valign="middle" width="100%" style="" > Message Of The Day The jr.p has: services.PortalToolkit.default.skin=orange-grey But it looks like it's not being used in this case. This same file used to produce portlet titles with grey backgrounds. Changing the psml to: <?xml version="1.0" encoding="UTF-8"?> <portlets id="200" xmlns="http://www.apache.org/2000/02/CVS";> <metainfo> <title>The CHEF Portal</title> </metainfo> <skin/> <entry id="100" parent="chef.motd"/> <entry id="101" parent="chef.intro"/> </portlets> Or <?xml version="1.0" encoding="UTF-8"?> <portlets id="200" xmlns="http://www.apache.org/2000/02/CVS";> <metainfo> <title>The CHEF Portal</title> </metainfo> <skin name="orange-grey"/> <entry id="100" parent="chef.motd"/> <entry id="101" parent="chef.intro"/> </portlets> Fixes it: <td align="left" nowrap="true" valign="middle" width="100%" class="TitleStyleClass" style="background-color: #dddddd; color: #000000;" > Message Of The Day I don't know if we should consider this a bug in the code or a bad psml file... - Glenn > -----Original Message----- > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]] > Sent: Tuesday, May 21, 2002 6:14 AM > To: [EMAIL PROTECTED] > Subject: cvs commit: > jakarta-jetspeed/src/java/org/apache/jetspeed/om/profile/psml > PsmlIdentityElement.java > > > paulsp 02/05/21 03:13:49 > > Modified: src/java/org/apache/jetspeed/om/profile/psml > PsmlIdentityElement.java > Log: > When a control, controller, layout, metainfo, or skin > element does NOT exist for > an entry, then one is created with no attributes, or sub elements. > > In the case of the skin, this is a problem since <Skin/> > means "Use the default > skin as define in JR.p" and no skin element will look up > the tree for a skin. > > Revision Changes Path > 1.2 +6 -6 > jakarta-jetspeed/src/java/org/apache/jetspeed/om/profile/psml/ > PsmlIdentityElement.java > > Index: PsmlIdentityElement.java > =================================================================== > RCS file: > /home/cvs/jakarta-jetspeed/src/java/org/apache/jetspeed/om/pro > file/psml/PsmlIdentityElement.java,v > retrieving revision 1.1 > retrieving revision 1.2 > diff -u -r1.1 -r1.2 > --- PsmlIdentityElement.java 22 Mar 2002 18:38:36 > -0000 1.1 > +++ PsmlIdentityElement.java 21 May 2002 10:13:49 > -0000 1.2 > @@ -65,22 +65,22 @@ > * suitable for Castor XML serialization. > * > * @author <a href="mailto:[EMAIL PROTECTED]";>David Sean Taylor</a> > - * @version $Id: PsmlIdentityElement.java,v 1.1 2002/03/22 > 18:38:36 taylor Exp $ > + * @version $Id: PsmlIdentityElement.java,v 1.2 2002/05/21 > 10:13:49 paulsp Exp $ > */ > public /*abstract*/ class PsmlIdentityElement extends > PsmlConfigElement implements IdentityElement, > java.io.Serializable > { > > private String id = null; > > - private MetaInfo metaInfo = new PsmlMetaInfo(); > + private MetaInfo metaInfo = null; > > - private Skin skin = new PsmlSkin(); > + private Skin skin = null; > > - private Layout layout = new PsmlLayout(); > + private Layout layout = null; > > - private Control control = new PsmlControl(); > + private Control control = null; > > - private Controller controller = new PsmlController(); > + private Controller controller = null ; > > public PsmlIdentityElement() > {} > > > > > -- > To unsubscribe, e-mail: > <mailto:jetspeed-dev-> [EMAIL PROTECTED]> > For > additional commands, > e-mail: <mailto:[EMAIL PROTECTED]> > -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
