[PATCH] Fixed images not being retrieved for PortletInstance

[Weaver, Scott]

Title: [PATCH] Fixed images not being retrieved for PortletInstance

The cause of this issue was that the JetspeedPortletFactory.getMetaData(PortletEntry) was only copying the title and the description into the returned MetaData object and omitting the image.

I added a getImage()convenience method to PortletEntry and BaseportletEntry then added logic to the getMetaData() method to properly build the returned MetaData object.

Scott

 

Index: JetspeedPortletFactoryService.java
===================================================================
RCS file: 
/home/cvspublic/jakarta-jetspeed/src/java/org/apache/jetspeed/services/portletfactory/JetspeedPortletFactoryService.java,v
retrieving revision 1.14
diff -u -r1.14 JetspeedPortletFactoryService.java
--- JetspeedPortletFactoryService.java  30 Jun 2002 18:55:38 -0000      1.14
+++ JetspeedPortletFactoryService.java  27 Sep 2002 15:37:42 -0000
@@ -490,6 +490,9 @@
 
         if ( entry.getDescription() != null )
             data.setDescription( entry.getDescription() );
+            
+        if ( entry.getImage() != null )
+            data.setImage( entry.getImage() );
 
         return data;
     }

Index: PortletEntry.java
===================================================================
RCS file: 
/home/cvspublic/jakarta-jetspeed/src/java/org/apache/jetspeed/om/registry/PortletEntry.java,v
retrieving revision 1.3
diff -u -r1.3 PortletEntry.java
--- PortletEntry.java   28 Mar 2002 23:13:14 -0000      1.3
+++ PortletEntry.java   27 Sep 2002 15:37:02 -0000
@@ -221,5 +221,13 @@
      */
     public void removeCategory(String name, String group);
     
+    /**
+     * Retrieves the image for this PortletEntry
+     * 
+     * @return String image defined for this PortletEntry
+     */
+    public String getImage();
+    
+    
 }
 

Index: BasePortletEntry.java
===================================================================
RCS file: 
/home/cvspublic/jakarta-jetspeed/src/java/org/apache/jetspeed/om/registry/base/BasePortletEntry.java,v
retrieving revision 1.3
diff -u -r1.3 BasePortletEntry.java
--- BasePortletEntry.java       28 Mar 2002 23:13:15 -0000      1.3
+++ BasePortletEntry.java       27 Sep 2002 15:36:40 -0000
@@ -486,6 +486,14 @@
     
 
 
+    /**
+     * @see org.apache.jetspeed.om.registry.PortletEntry#getImage()
+     */
+    public String getImage()
+    {
+        return getMetaInfo().getImage();
+    }
+
 }
 
 


--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>