> -----Original Message-----
I have done so limited testing, and it doesn't seem to break anything.
Scott
> From: Weaver, Scott [mailto:[EMAIL PROTECTED]]
> Sent: Wednesday, October 02, 2002 1:31 PM
> To: 'Jetspeed Developers List'
> Subject: RE: [control.xreg] <portlet-control-entry name="TitlePortletContr
> ol" ...
>
> I've got the code in place, gettin' ready to test it now.
>
> Scott
>
> > -----Original Message-----
> > From: Mark Orciuch [mailto:[EMAIL PROTECTED]]
> > Sent: Wednesday, October 02, 2002 12:54 PM
> > To: Jetspeed Developers List
> > Subject: RE: [control.xreg] <portlet-control-entry
> > name="TitlePortletControl" ...
> >
> > Well, looks like the JetspeedPortalToolkitService.getSet() is what needs
> > to
> > be enhanced with handling of the "_control" parameter.
> >
> > Best regards,
> >
> > Mark C. Orciuch
> > Next Generation Solutions, Ltd.
> > e-Mail: [EMAIL PROTECTED]
> > web: http://www
> >
> > > -----Original Message-----
> > > From: Amedeo Zottola [mailto:[EMAIL PROTECTED]]
> > > Sent: Wednesday, October 02, 2002 11:42 AM
> > > To: Jetspeed Developers List
> > > Subject: R: [control.xreg] <portlet-control-entry
> > > name="TitlePortletControl" ...
> > >
> > >
> > > Ok,
> > > this is a great idea! :)
> > > how can i help you?!
> > > Amedeo.
> > >
> > > > -----Messaggio originale-----
> > > > Da: Mark Orciuch [mailto:[EMAIL PROTECTED]]
> > > > Inviato: mercoled� 2 ottobre 2002 18.30
> > > > A: Jetspeed Developers List
> > > > Oggetto: RE: [control.xreg] <portlet-control-entry
> > > > name="TitlePortletControl" ...
> > > >
> > > >
> > > > Great! I was going to look into this but I'd have to
> > > > familiarize myself with
> > > > the way portlets are "decorated" with controls. Look like
> > > > you're in that
> > > > "zone" right now. I was thinking about something like adding
> > > > "_control"
> > > > parameter in registry which would override the default control.
> > > >
> > > > One other enhancement on my todo list is to add control list
> > > > box for each
> > > > portlet shown in the portlet set customizer. This way, users
> > > > can assign
> > > > controls to each portlet individually.
> > > >
> > > > Best regards,
> > > >
> > > > Mark C. Orciuch
> > > > Next Generation Solutions, Ltd.
> > > > e-Mail: [EMAIL PROTECTED]
> > > > web: http://www.ngsltd.com
> > > >
> > > >
> > > > > -----Original Message-----
> > > > > From: Weaver, Scott [mailto:[EMAIL PROTECTED]]
> > > > > Sent: Wednesday, October 02, 2002 11:22 AM
> > > > > To: 'Jetspeed Developers List'
> > > > > Subject: RE: [control.xreg] <portlet-control-entry
> > > > > name="TitlePortletControl" ...
> > > > >
> > > > >
> > > > > > Do you always want to use this control with particular portlet?
> > > > >
> > > > > Actually, I would like to see this implemented. I would like to
> > > > > be able to set control entries in the registry for individual
> > > > > portlet entries. I might take a look at what this would since I
> > > > > have been poking around the control code. Plus, it seems to be
> > > > > what some of my sales guys would like to see.
> > > > >
> > > > > Scott
> > > > >
> > > >
> > > >
> > > > --
> > > > To unsubscribe, e-mail:
> > > > <mailto:[EMAIL PROTECTED]>
> > > > For additional commands, e-mail:
> > > > <mailto:[EMAIL PROTECTED]>
> > > >
> > > >
> > >
> > > --
> > > To unsubscribe, e-mail:
> > <mailto:[EMAIL PROTECTED]>
> > For additional commands, e-mail:
> > <mailto:[EMAIL PROTECTED]>
> >
> >
> > --
> > To unsubscribe, e-mail: <mailto:jetspeed-dev-
> > [EMAIL PROTECTED]>
> > For additional commands, e-mail: <mailto:jetspeed-dev-
> > [EMAIL PROTECTED]>
Index: JetspeedPortalToolkitService.java
===================================================================
RCS file:
/home/cvspublic/jakarta-jetspeed/src/java/org/apache/jetspeed/services/portaltoolkit/JetspeedPortalToolkitService.java,v
retrieving revision 1.21
diff -u -r1.21 JetspeedPortalToolkitService.java
--- JetspeedPortalToolkitService.java 30 Jun 2002 05:23:19 -0000 1.21
+++ JetspeedPortalToolkitService.java 2 Oct 2002 17:45:56 -0000
@@ -201,6 +201,34 @@
return pc;
}
+
+
+ protected PortletControl getControl( Control control, PortletEntry entry )
+ {
+ PortletControl pc = null;
+
+ if (control != null)
+ {
+ pc = getControl(control.getName());
+ pc.getConfig().getInitParameters().putAll(getParameters(control));
+ }
+ else
+ {
+ org.apache.jetspeed.om.registry.Parameter dftPortletCtrl =
+ entry.getParameter("_control");
+
+ if (dftPortletCtrl != null)
+ {
+ pc = getControl(dftPortletCtrl.getValue());
+ }
+ else if (defaultControl != null)
+ {
+ pc = getControl(this.defaultControl);
+ }
+ }
+
+ return pc;
+ }
/**
@@ -430,7 +458,7 @@
Map constraints = getParameters(psmlEntry.getLayout());
int position = getPosition( psmlEntry.getLayout() );
- PortletControl control = getControl(psmlEntry.getControl());
+ PortletControl control = getControl(psmlEntry.getControl(),
+entry);
set.addPortlet( initControl(control,p),
controller.getConstraints( constraints ),-- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
