I'm currently -0 for this change: I agree that it may make sense but OTOH it may break existing behavior of running portals which would be a bad thing.
Unless other dev step in to include this change, I'd advise you currently to simply use a custom CreateNewUserAction class. You can achieve this transparently by creating a new action class of this name in your own package and include this package in the *beginning* of Turbine modules search path. ie 1. Create com.mycom.modules.actions.CreateNewUserAction to suit your need 2. Add in my.properties: module.packages=com.mycom.modules This should make Turbine look first in your modules packages before looking into the default jetseed and turbine ones. > -----Message d'origine----- > De : Aurelien Pernoud [mailto:apernoud@;sopragroup.com] > Envoy� : mardi 5 novembre 2002 16:52 > � : 'Jetspeed Developers List' > Objet : [Patch] was RE: Creating new user skips the Login > class => bug, > enhancement ? > > > > Could some dev please have a look at this or tell me why it's > not wanted as > the default behaviour in Jetspeed ? > > Thanks, > Aurelien > > > -----Message d'origine----- > > De : Aurelien Pernoud [mailto:apernoud@;sopragroup.com] > > Envoy� : lundi 4 novembre 2002 11:23 > > � : 'Jetspeed Developers List' > > Objet : RE: Creating new user skips the Login class => bug, > > enhancement > > ? > > > > > > > > I just tried the modification above, it works fine. I don't > > know cvs yet but > > the changes are minor but useful I think. > > > > If anyone can apply it to jetspeed... ? Just a change of one > > line, to be > > sure to do the login when creating new user. > > > > Thx, > > Aurelien > > > > > -----Message d'origine----- > > > De : Aur�lien Pernoud [mailto:apernoud@;sopragroup.com] > > > Envoy� : mardi 15 octobre 2002 15:40 > > > � : 'Jetspeed Developers List' > > > Objet : Creating new user skips the Login class => bug, > > enhancement ? > > > > > > > > > > > > Hi there, > > > > > > I've extended the JLoginUser for my needs, but I'm stuck with > > > a little issue > > > : > > > When I'm creating a new user (without confirming by email), I > > > directly go to > > > the portal with defaults portlets, but it doesn't go > > through the Login > > > part... So some of my initializing is missing, so portlets > > > have errors. I > > > have to logout first, and then log in to have portlets get > > > their content. > > > > > > I see I can modify the CreateNewUserAndConfirm action to > > > perform the login > > > after, but there's no line allowing to change the default > action for > > > creation in js.pr (did I miss it ???). > > > > > > Shouldn't the fonctionnement be : > > > "Create New User" => if no confirm wanted => Login, cause now > > > as I saw in > > > the source it only does : > > > (line 207) > > > if (!enableMail && !newUserApproval) // > > > (That's my case, and > > > it's the default case) > > > { > > > user.setHasLoggedIn(new Boolean (true)); > > > user.setLastLogin(new Date(0)); > > > } > > > > > > And this skips the default login that may have been changed. > > > > > > I'm not quite sure, but I think we could change this with : > > > > > > if (!enableMail && !newUserApproval) > > > { > > > ActionLoader.getInstance().exec(data, > > > JetspeedResources.getString("action.login")); > > > } > > > > > > I can't test cause I don't want to change Jetspeed src for my > > > needs, but it > > > must work. > > > > > > Thanks for considering request, > > > > > > Aur�lien Pernoud > > > -- > To unsubscribe, e-mail: > <mailto:jetspeed-dev-unsubscribe@;jakarta.apache.org> > For additional commands, e-mail: > <mailto:jetspeed-dev-help@;jakarta.apache.org> > -- To unsubscribe, e-mail: <mailto:jetspeed-dev-unsubscribe@;jakarta.apache.org> For additional commands, e-mail: <mailto:jetspeed-dev-help@;jakarta.apache.org>
