I gave it a quick review.
A few comments:

There's a lot of this kind of stuff:

      out.append("<h2>Portal Messenger</h2>");
      out.append("<form
action=\"http://"+request.getServerName()+"/jetspeed/portal\"
method=\"post\">");
      out.append("<br>Sent to: <select size=\"1\" name=\"option\"> <option
selected>email</option><option>forum</option><option>both</option></select>"
);

Its an unwritten rule to always use templates for all content (don't hard
code html in java)

We can't hard code connection info in Java. Jetspeed uses Torque or at least
a configurable data source, and has to be db agnostic

  public static String
dbDriver="org.gjt.mm.mysql.Driver";//TurbineResources.getString("database.de
fault.driver");
  public static String
dbUsername="root";//TurbineResources.getString("database.default.username");
  public static String
dbPassword="";//TurbineResources.getString("database.default.password");
  public static String dbURL=
"jdbc:mysql://evlach.syros.aegean.gr:3306/myforum";
//TurbineResources.getString("database.default.url");

Recommend using Torque for the DB stuff

This is mySQL specific:

    String  q = "SHOW FIELDS FROM " + table; //get columns


David



--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

Reply via email to