David, Yeah, we have been using it quite extensively. I have other changes to this and the base HTMLRewriter but need to finish evaluating them to make sure they are general.
I think this new rewriter framework is a big enhancement over the previous design. Thanks for all the work. marcus -----Original Message----- From: David Sean Taylor [mailto:[EMAIL PROTECTED]] Sent: Wednesday, November 27, 2002 9:36 AM To: Jetspeed Developers List Subject: RE: org.apache.jetspeed.util.rewriter.SwingParserAdaptor always translates Method to be a POST > -----Original Message----- > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]] > Sent: Wednesday, November 27, 2002 7:39 AM > To: [EMAIL PROTECTED] > Subject: org.apache.jetspeed.util.rewriter.SwingParserAdaptor always > translates Method to be a POST > > > Hello, > I ran into a problem where the > org.apache.jetspeed.util.rewriter.SwingParserAdaptor is always translating > the form methods to be POST. Good to see someone using the new rewriter framework. +1 on your fix if no one objects i'll commit it later today > > Is there a reason why we would always want to do a POST and not > allow other > methods such as GET? > > I propose the following to keep from arbitrarily changing form methods to > POST: > > In Callback.convertURLS(Tag, MutableAttributeSet) - > > } else if (tag == HTML.Tag.FORM) > { > // ---- CHECKING <FORM ACTION= > inForm = true; // buggy <form> handling in jdk 1.3 > > //MM - fix problem of always translating method to POST. > if (attrs.getAttribute(HTML.Attribute.METHOD) == null) > { > // always post > attrs.addAttribute(HTML.Attribute.METHOD, "POST"); > > } > if (attrs.getAttribute(HTML.Attribute.ACTION) == null) > { > //MM - removed as part of fix > // always post > //attrs.addAttribute(HTML.Attribute.METHOD, "POST"); > > //self referencing <FORM> > attrs.addAttribute(HTML.Attribute.ACTION, > baseURL); > } else > { > //MM - removed as part of fix > // always post > //attrs.addAttribute(HTML.Attribute.METHOD, > "POST"); > addProxiedConvertedAttribute( tag, > HTML.Attribute.ACTION, attrs); > } > } > > If no one has any suggestions I would appreciate someone committing this > change to cvs. > > thank you, > > marcus > > -- > To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]> -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]> -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
