This patch should fix case 5. It also includes a JUnit test that emulates each of the 5 test cases. My first patch should be applied before this one.
The test cases along with actual testing via the customizer appear to be working correctly.
Sorry for the delay,
Scott
> -----Original Message-----
> From: Glen Carl [mailto:[EMAIL PROTECTED]]
> Sent: Tuesday, January 07, 2003 3:35 PM
> To: Jetspeed Developers List
> Subject: New skin algorithm problem for current CVS Head 1.4b4
>
> New problem for current CVS Head 1.4b4:
> Looks like a test 5 was needed, since we have a new trouble.
>
> 5) a) login as turbine
> b) verify no skin tags in default.psml
> c) Customize HTML
> d) Select new skin like orange-red and apply
> e) now view default.psml and verify only skin tag at top of
> default.psml
>
> Currently, this test fails, since every portlets tag gets a skin tag. I
> would guess there is a recursive set. My request is to have the
> recursion eliminated.
>
> Thanks,
> Glen
>
> The following tests still pass
> 1) no skin ref in PSML
> > RESULT: uses default skin
> >
> > 2) skin set a top level, no skin setting for children portlets
> > RESULT: children portlets use the top level skin setting
> >
> > 3) skin set at top level, and skin set in child portlet
> > RESULT: uses skin assigned for child portlet
> >
> > 4) no skin at top level, and skin set in child portlet
> > RESULT: uses skin assigned for child portlet, and all other portlets
> use
>
>
> Glen Carl wrote:
> > All 4 tests passed beautifully! Nice work.
> > Sorry, I am unable to update bugzilla, since I do not have an account.
> > Whoever does, can you resolve bug 14909 as fixed.
> > Thanks,
> > Glen
> >
> > David Sean Taylor wrote:
> >
> >>
> >> On Friday, January 3, 2003, at 12:16 PM, Weaver, Scott wrote:
> >>
> >>> The actual patch files:
> >>>
> >>> Scott
> >>>
> >>> <patch-Portlets.txt><patch-PsmlPortlets.txt><patch-
> >>> JetspeedPortalToolkitService.txt>--
> >>> To unsubscribe, e-mail:
> >>> <mailto:[EMAIL PROTECTED]>
> >>> For additional commands, e-mail:
> >>> <mailto:[EMAIL PROTECTED]>
> >>
> >>
> >>
> >> Patches applied to CVS head. Glen, could you please retest. If it
> >> passes your 4 tests, could you update the bugzilla status?
> >>
> >> Thanks,
> >>
> >> --
> >> David Sean Taylor
> >> Bluesunrise Software
> >> [EMAIL PROTECTED]
> >> +01 707 773-4646
> >
> >
> >
> > --
> > To unsubscribe, e-mail:
> > <mailto:[EMAIL PROTECTED]>
> > For additional commands, e-mail:
> > <mailto:[EMAIL PROTECTED]>
> >
> >
>
>
> --
> To unsubscribe, e-mail: <mailto:jetspeed-dev-
> [EMAIL PROTECTED]>
> For additional commands, e-mail: <mailto:jetspeed-dev-
> [EMAIL PROTECTED]>
fix_skin_aggregation.zip
Description: Binary data
-- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
