Aurelien, Thanks for pointing this out, the logic should be:
if (object == null || !(object instanceof SecurityAccess)) I just committed the change. Thanks again, *================================* | Scott T Weaver | | <[EMAIL PROTECTED]> | | Apache Jetspeed Portal Project | | Apache Pluto Portlet Container | *================================* > -----Original Message----- > From: Pernoud Aurelien [mailto:[EMAIL PROTECTED] > Sent: Thursday, November 06, 2003 3:17 AM > To: Jetspeed Developers List > Subject: RE: cvs commit: jakarta- > jetspeed/src/java/org/apache/jetspeed/om/registry/base > BaseSecurityAccess.java > > > [EMAIL PROTECTED] a �crit : > > > > * Interface for manipulatin the Security Access on the registry > > entries @@ -93,38 +94,38 @@ > > */ > > public boolean equals(Object object) > > { > > - if (object == null) > > + if (object == null || (object instanceof SecurityAccess)) > > { > > return false; > > } > > > > - BaseSecurityAccess obj = (BaseSecurityAccess) object; > > + SecurityAccess obj = (SecurityAccess) object; > > I have no idea what this is supposed to do, but I don't get the test... > You test if 'object' is an instance of securityacess and return false, and > if it isn't you try to cast it as a securityaccess ? > Shouldn't it be a "not instance of SecurityAccess" : > + if (object == null || !(object instanceof SecurityAccess)) > > Again, I just looked the code, I don't know what this is supposed to do so > I might really be wrong, I was just wondering :) > > Aurelien > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED]
