taylor      2004/07/06 16:31:54

  Modified:    components/registry/src/java/org/apache/jetspeed/om/portlet/impl
                        PortletApplicationDefinitionImpl.java
  Log:
  always get back a collection, never null (good citizen rule)
  
  completed  JS2-70 -- Support service definitions in Jetspeed portlet descriptor
  this commit completes step 2, validation
  
  http://nagoya.apache.org/jira/browse/JS2-70
  
  CVS: ----------------------------------------------------------------------
  CVS: PR:
  CVS:   If this change addresses a PR in the problem report tracking
  CVS:   database, then enter the PR number(s) here.
  CVS: Obtained from:
  CVS:   If this change has been taken from another system, such as NCSA,
  CVS:   then name the system in this line, otherwise delete it.
  CVS: Submitted by:
  CVS:   If this code has been contributed to Apache by someone else; i.e.,
  CVS:   they sent us a patch or a new module, then include their name/email
  CVS:   address here. If this is your work then delete this line.
  CVS: Reviewed by:
  CVS:   If we are doing pre-commit code reviews and someone else has
  CVS:   reviewed your changes, include their name(s) here.
  CVS:   If you have not had it reviewed then delete this line.
  
  Revision  Changes    Path
  1.14      +2 -11     
jakarta-jetspeed-2/components/registry/src/java/org/apache/jetspeed/om/portlet/impl/PortletApplicationDefinitionImpl.java
  
  Index: PortletApplicationDefinitionImpl.java
  ===================================================================
  RCS file: 
/home/cvs/jakarta-jetspeed-2/components/registry/src/java/org/apache/jetspeed/om/portlet/impl/PortletApplicationDefinitionImpl.java,v
  retrieving revision 1.13
  retrieving revision 1.14
  diff -u -r1.13 -r1.14
  --- PortletApplicationDefinitionImpl.java     6 Jul 2004 21:30:04 -0000       1.13
  +++ PortletApplicationDefinitionImpl.java     6 Jul 2004 23:31:54 -0000       1.14
  @@ -66,7 +66,7 @@
       private Collection metadataFields = null;
   
       /** Metadata property */
  -    private Collection services = null;
  +    private Collection services = new ArrayList();
       
       /** Description */
       private String description;
  @@ -343,11 +343,6 @@
        */
       public Collection getJetspeedServices()
       {
  -        if(services == null)
  -        {
  -            services = new ArrayList();
  -        }
  -        
           return services;
       }
       
  @@ -356,10 +351,6 @@
        */
       public void addJetspeedService(JetspeedServiceReference service)
       {
  -        if(services == null)
  -        {
  -            services = new ArrayList();
  -        }
           services.add(service);
       }
   
  
  
  

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to