[J2] JetpseedPortletServices should not be used in PortletApplicationWar

[Scott T. Weaver]

I notcied that an evil static factory, JetspeedPortletServices, has 
crept into PortletApplicationWar.  It appears that it is being used to 
validate that services required by a PortletApp actually exist when 
creating the app. 

I am a heavy -1 on this because:
1. it requires that the Engine/Portlet Serevices be running to be able 
to use PAW.
2. it is in serve violation of the pico good citizen mantra we have been 
trying to adhere to. 
3. Adding such a heavy dependency to such a light-weight object, 
especially via a static factory, is not a good idea.

I would like to see this moved into JetpseedPortletFactory and validate 
services at runtime instead of at deployment.  Besides the reasons I 
have mentioned, this a better approach for the simple reason that if a 
service is removed AFTER a portlet app is deployed, the portlet app is 
now in an inconsistent state since the service no longer exists yet your 
app is still deployed and running.

I know I am starting to sound like a real ass in regards to these types 
of things, but we have been working our butts of to get everything 
dependency injected and making J2 architecture super-tight, this just a 
step backwards for us.

Regards,
--
******************************************
*           Scott T. Weaver              *
*         <[EMAIL PROTECTED]>            *
*     <http://www.einnovation.com>       *
* -------------------------------------- *
*   Apache Jetspeed Enterprise Portal    *
*     Apache Pluto Portlet Container     *
*                                        *
* OpenEditPro, Website Content Mangement *
*     <http://www.openeditpro.com>       *
******************************************
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]