I think something got messed up between the patch that I submitted
and what came through SVN.
My patch added double quotes "" around a jsp tag <%=value%>
the SVN change removes what _appears_ to be a double >>
at the end of the tag.
However both of the > should be in place. the first closes the JSP tag
the second closes the <A> HTML tag. however they should have
the " in between the since href attribute needs to be quoted.
For me the non-modified version generated a non-quoted href tag
eg:
<a target="_blank"
href=http://portals.apache.org/jetspeed-2/ >Jetspeed-2 Site</a><br>
-C-
On Dec 5, 2005, at 9:55 PM, James Liao wrote:
IMHO, the original one is correct, it will generate the following
html:
<a target="_blank"
href="http://portals.apache.org/jetspeed-2/";>Jetspeed-2 Site</a><br>
<a target="_blank" href="http://www.bluesunrise.com/";>Bluesunrise
Site</a><br>
<a target="_blank" href="http://www.apache.org/";>Apache Home</a><br>
The new one:
<a target="_blank"
href="http://portals.apache.org/jetspeed-2/Jetspeed-2";
site=""></a><br>
<a target="_blank" href="http://www.bluesunrise.com/Bluesunrise";
site=""></a><br>
<a target="_blank" href="http://www.apache.org/Apache"; home=""></
a><br>
- Jian Liao
On 12/6/05, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote:
Author: taylor
Date: Mon Dec 5 20:30:30 2005
New Revision: 354298
URL: http://svn.apache.org/viewcvs?rev=354298&view=rev
Log:
patch from Chris Schaefer
Modified:
portals/jetspeed-2/trunk/applications/demo/src/webapp/WEB-INF/
view/bookmark-
view.jsp
Modified:
portals/jetspeed-2/trunk/applications/demo/src/webapp/WEB-INF/view/
bookmark-
view.jsp
URL:
http://svn.apache.org/viewcvs/portals/jetspeed-2/trunk/
applications/demo/src/webapp/WEB-INF/view/bookmark-view.jsp?
rev=354298&r1=354297&r2=354298&view=diff
=====================================================================
=========
---
portals/jetspeed-2/trunk/applications/demo/src/webapp/WEB-INF/view/
bookmark-
view.jsp (original)
+++
portals/jetspeed-2/trunk/applications/demo/src/webapp/WEB-INF/view/
bookmark-
view.jsp Mon Dec 5 20:30:30 2005
@@ -25,7 +25,7 @@
(name,"<"+
myText.getString("undefined")+">");
%>
- <A target="_blank" HREF=<%=value%>><%=name%></A><BR>
+ <A target="_blank" HREF=<%=value%><%=name%></A><BR>
<%
}
%>
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
