Just getting this thread on the dev list...
Randy
--- Begin Message ---
Shinsuke/All,
It turns out that getting the edit page actions, (i.e. customizer), to
work in nested layout is non-trivial and broken even if we managed to
get the paths to the images correct. Furthermore, page actions are now
part of the header.vm decorator and no longer should be handled in the
tcolumns layout template.
So, I am simply going to remove them as was done with the columns
template. This should not effect the tests done by all earlier on the
table layouts.
Fixing the customizer to work with nested layouts is another can of
worms I am not opening now!
Randy
On Fri, 2006-01-13 at 08:33 +0900, Shinsuke SUGAYA wrote:
> Randy Watler wrote:
> > Shinsuke,
> >
> > Thanks for your time. I too noticed the broken edit image with the
> > tcolumns layout. tcolumns is the old tables based layout Scott
> > replaced... I simply added a page that actually uses them since they are
> > still used by plenty of J2 clients. There are plenty of those kinds of
> > things lurking in the darker corners of the decorator/layout world. It
> > is probably simple to fix, so I'll take a look at it tonight before I
> > commit.
>
> I see. Thanks!
> - shinsuke
>
> > Randy
> >
> >
> > On Fri, 2006-01-13 at 07:27 +0900, Shinsuke SUGAYA wrote:
> >> Hi Randy,
> >>
> >> Thank you for your hard work.
> >> I checked it on:
> >>
> >> 1. Japanese Firefox 1.5
> >> 2. Japanese IE6
> >>
> >> It looks good!
> >>
> >> My question is that the nested table layouts page(not nested layouts page)
> >> is under development now? Some images(edit.gif..) in the nested fragment
> >> are missing.
> >>
> >> Thanks,
> >> shinsuke
> >>
> >> Randy Watler wrote:
> >>> Ate, Scott, David, Shinsuke:
> >>>
> >>> Ok, I think I am finally done with this stuff for now. Attached is a
> >>> patch file... please review today sometime if you'd like and have the
> >>> time. I appreciate it. Assuming you all approve I'll commit tonight to
> >>> the trunk and 2.0.1 branch.
> >>>
> >>> I have tested on FireFox, Mozilla, IE6, and IE5 and it looks fairly
> >>> good. I do not have access to Safari, but it should work there as well.
> >>> One can spend an infinite amount of time messing with this, but I think
> >>> this is fairly good and I have already spent more time on it than I
> >>> actually have to spare.
> >>>
> >>> Thanks,
> >>>
> >>> Randy
> >>>
> >>>
> >> --------------------------------------
> >> Yahoo! Mail - supported by 10million people
> >> http://pr.mail.yahoo.co.jp/mail_pr/
> >>
> >
> >
>
> --------------------------------------
> Yahoo! Mail - supported by 10million people
> http://pr.mail.yahoo.co.jp/mail_pr/
>
--- End Message ---
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
