There is something mysterious about the build.bat file (/products/cvs/jetspeed/jetspeed/build/build.bat, revision 1.6). I wanted to make suggestions to add couple of new lines there, however, each time I made a diff (with jCVS), it returned the whole file. (At the same time everything looked just fine under command shell.) I finally changed my CVS client for winCVS and discovered what was wrong with it: The problem is that instead of CR-LF in the end of each line, there is CR-CR-LF in the end of each line. (And jCVS converted these into CR-LF's when storing files on my system but complained when making a diff). I suggest to convert this file to standard CR-LF so people can make meaningful diffs. My original suggestion for changing the build.bat is to include one more package (tools.jar) explicitly into the classpath (see diff below). I have already twice ran into problems when trying to compile it without this package. Also, maybe it would be more meaningful to include the full name of the "Java Servlet Development Kit" instead of JSDK. As I'm new to Java (especially servlets), I first thought this abbreviation could stand for Java Self Development Kit. However, as I didn't find any reference anywhere to such thing I thought that it could then be a spelling mistake and it was supposed to be JDK. So, to make things clearer for newbies, I suggest to change this in two places: build.bat and README. So the changes to the "build.bat" would be, in the form of a manual diff: D:\temp>diff build_old.bat build_new.bat 29c29 < REM Define the path to your JSDK --- > REM Define the path to your Java Servlet Development Kit (JSDK) 32a33,37 > REM ------------------------------------------------------------------- > REM Define the path to your tools package from JDK > REM ------------------------------------------------------------------- > set TOOLS=d:\java\lib\tools.jar > 47c52 < set CP=%JSDK%;%ECS%;%TURBINE%;%COCOON%;%CASTOR%;%VILLAGE%;%XALAN%;%XERCES%;a nt.jar;projectx-tr2.jar;javac.jar --- > set CP=%JSDK%;%TOOLS%;%ECS%;%TURBINE%;%COCOON%;%CASTOR%;%VILLAGE%;%XALAN%;%X ERCES%;ant.jar;projectx-tr2.jar;javac.jar And changes to README: Index: README =================================================================== RCS file: /products/cvs/jetspeed/jetspeed/build/README,v retrieving revision 1.1 diff -r1.1 README 6c6 < - JSDK 2.2 (Servlet API 2.2 from Tomcat) --- > - Java Servlet Development Kit (JSDK) 2.2 (Servlet API 2.2 from Tomcat) Just my little contribution, Neeme -- -------------------------------------------------------------- Please read the FAQ! <http://java.apache.org/faq/> To subscribe: [EMAIL PROTECTED] To unsubscribe: [EMAIL PROTECTED] Archives and Other: <http://java.apache.org/main/mail.html> Problems?: [EMAIL PROTECTED]
