Rapha�l Luta wrote:
>
> burtonator wrote:
> >
> > Just as a head up.
> >
> > I would like to start a migration of PortletFactory into util classes
> > under org.apache.jetspeed.portal.factory.util.portletfactory.
> >
> > We are clearly putting too much code into PortletFactory (currently at a
> > heft 1250 lines). There are some clearly redundant operations here so
> > any new functionality should go into util classes.
>
> +1, I was thinking of splitting PortletFactory in 2 before my vacation but
> didn't find time:
>
> - PortletFactory for handling the getPortlet(xxxx) calls which are used
> in many places in the code and which are not dependant on the PSML URL
> used
>
> - SiteFactory for handling all the PSML related stuff, mainly the
> getPortlets(xxx) calls
>
> - The private utility methods at the end of the class would either go into
> SiteFactory or util classes
>
> I can certainly implement this next week, after 1.1.5
> --
+1. Also, since we have all the getPortlet() overloaded methods it
would be cool to have a private getPortletImpl() just to ease
development so that you always know where Portlets are "really"
instantiated.
Kevin
--
Kevin A Burton ([EMAIL PROTECTED])
http://relativity.yi.org
Message to SUN: "Please Open Source Java!"
I just patented "one click e-mail", when you hit the "reply" button you
own me 50 cents.
--
--------------------------------------------------------------
Please read the FAQ! <http://java.apache.org/faq/>
To subscribe: [EMAIL PROTECTED]
To unsubscribe: [EMAIL PROTECTED]
Archives and Other: <http://java.apache.org/main/mail.html>
Problems?: [EMAIL PROTECTED]
