Title: Bug in JetspeedBottomNavigation.java

My comments marked with "G>":


public class JetspeedBottomNavigation extends Navigation
{
    private static String siteLogo = JetspeedResources.getInstance()
            .getString( JetspeedResources.SITE_FOOTER_LOGO_KEY );

    G> In a default config, siteLogo == /content/images/feather.gif,
    G> therefore it is not empty, so doBuild() jumps to...


    private static String LOGO_IMAGE;

  
    public ConcreteElement doBuild( RunData data ) throws Exception
    {
        //TODO:  Import a standard HTML footer here...  Possibly as a FileServerPortlet
        if (siteLogo == "" )
            siteLogo = TurbineResources.getString( "site.footer.logo" );
        if (siteLogo == "" )
            siteLogo = "/images/feather.gif";

        G> ... here!!!

        LOGO_IMAGE = JetspeedResources.getInstance()
            .getString( JetspeedResources.CONTENT_ROOT_URL_KEY ) + siteLogo;

        G> In a default config, CONTENT_ROOT_URL_KEY is /content, so
        G> this ends up being /content/content/images/feather.gif,
        G> and this URL does not exist.

        ElementContainer root = new ElementContainer();
        root.addElement( new HR() );
        root.addElement( new IMG( LOGO_IMAGE ).setAlign("right") );
        return root;

    }
}

Thanks,


--
Gonzalo A. Diethelm
[EMAIL PROTECTED]
If this mail is in HTML format, blame Exchange Server: Q222508

Reply via email to