-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
"Carol Jones/Raleigh/IBM" <[EMAIL PROTECTED]> writes:
> in org.apache.jetspeed.util.Util, this method has a hard-coded URL for the
> default style sheet. Really, that should come from JetspeedProperties I
> guess.
This method is a holdover from days of yore. This should migrate to a property
and all method calls (there might be one or two) should use the propert.
> public static Link getCSS() {
> return new Link().setRel("stylesheet")
> .setType("text/css")
> .setHref( "/content/css/default.css" );
> }
>
> There are also some problems with the way
> org.apache.jetspeed.turbine.layouts.JetspeedLayout is written. Namely, it
> is letting the top navigation class put the CSS link into the markup, but
> that means the tag will appear in the body, not in the <HEAD> section.
hmmm... Well the TopNavigation should just be patched to put this into the
<head> section. I believe it still has access.
> Another problem is that it's setting the title and background color
> unconditional. Really, it should not set these at all, they should come
> from the skin tags and from the CSS, respectively.
Yes. I agree.
> In the scheme of things, these are not a big deal--I can easily work around
> them by writing my own layout class. But they would be pretty easy to fix.
There are a lot of areas of Jetspeed which should be refactored when pushing
towards 2.0. I see a lot of things changing. I think the DiskCache should
become InMemoryProxy and Avalonized. Everything else should be Avalon. Issues
like this will be picked up in the refactor.
- --
Kevin A. Burton ( [EMAIL PROTECTED], [EMAIL PROTECTED], [EMAIL PROTECTED] )
Learn from other people's mistakes, you don't have time to make your own.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.1 (GNU/Linux)
Comment: Get my public key at: http://relativity.yi.org/pgpkey.txt
iD8DBQE5+aNXAwM6xb2dfE0RAuu0AJ9Y65G5q8X6u/d3DKz8rC/HeCY3sACePtE1
6cV1yJTman05ZfRXJ9mEd5Q=
=NsKM
-----END PGP SIGNATURE-----
CIA genetic smuggle NORAD Rule Psix colonel Ortega counter-intelligence World
Trade Center Qaddafi bomb terrorist munitions kibo BATF
--
--------------------------------------------------------------
Please read the FAQ! <http://java.apache.org/faq/>
To subscribe: [EMAIL PROTECTED]
To unsubscribe: [EMAIL PROTECTED]
Archives and Other: <http://java.apache.org/main/mail.html>
Problems?: [EMAIL PROTECTED]
